[GitHub] carbondata pull request #2884: [CARBONDATA-3063] Support set and get carbon ...

classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2884: [CARBONDATA-3063] Support set and get carbon ...

qiuchenjian-2
GitHub user xubo245 opened a pull request:

    https://github.com/apache/carbondata/pull/2884

    [CARBONDATA-3063] Support set and get carbon property in C++ SDK

    when user write CarbonData or read CarbonData in C++ SDK, user maybe need to change or add carbon property to avoid some problem. such as OOM.
    So we support set and get carbon property in C++ SDK
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     No
     - [ ] Any backward compatibility impacted?
     No
     - [ ] Document update required?
    Yes
     - [ ] Testing done
        add test case in C++ code
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    Jira2951


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xubo245/carbondata CARBONDATA-3063_setProperty

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2884.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2884
   
----
commit 854757ae2e399e429d75b11c5292264e22ec7eb9
Author: xubo245 <xubo29@...>
Date:   2018-10-31T06:41:21Z

    [CARBONDATA-3063] Support set and get carbon property in C++ SDK

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2884: [CARBONDATA-3063] Support set and get carbon propert...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2884
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1175/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2884: [CARBONDATA-3063] Support set and get carbon propert...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2884
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1388/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2884: [CARBONDATA-3063] Support set and get carbon propert...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2884
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9439/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2884: [CARBONDATA-3063] Support set and get carbon propert...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2884
 
    @KanakaKumar Please review it.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2884: [CARBONDATA-3063] Support set and get carbon propert...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2884
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1221/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2884: [CARBONDATA-3063] Support set and get carbon propert...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2884
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1436/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2884: [CARBONDATA-3063] Support set and get carbon propert...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2884
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9485/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2884: [CARBONDATA-3063] Support set and get carbon propert...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2884
 
    @kanaka  CI PASS .please check


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2884: [CARBONDATA-3063] Support set and get carbon propert...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user kanaka commented on the issue:

    https://github.com/apache/carbondata/pull/2884
 
    @xubo245 I think you meant @KanakaKumar


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2884: [CARBONDATA-3063] Support set and get carbon propert...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2884
 
    @KanakaKumar  CI PASS .please check


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2884: [CARBONDATA-3063] Support set and get carbon propert...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2884
 
    @kanaka yes, sorry


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2884: [CARBONDATA-3063] Support set and get carbon propert...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user KanakaKumar commented on the issue:

    https://github.com/apache/carbondata/pull/2884
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2884: [CARBONDATA-3063] Support set and get carbon propert...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user QiangCai commented on the issue:

    https://github.com/apache/carbondata/pull/2884
 
    ok, merge to master


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2884: [CARBONDATA-3063] Support set and get carbon ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2884


---