[GitHub] carbondata pull request #2899: [CARBONDATA-3073] Support configure TableProp...

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2899
 
    @KanakaKumar CI pass, please review it.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2899
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1394/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2899
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1605/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2899
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9653/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2899
 
    @KanakaKumar @jackylk @QiangCai @ajantha-bhat Please review it.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2899
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1499/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2899
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9756/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2899
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1708/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2899
 
    @KanakaKumar @jackylk @QiangCai @ajantha-bhat @kunal642 Please review it.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2899
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1620/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2899
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1831/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2899
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9880/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2899
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2899
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1626/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2899
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9886/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2899
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1837/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2899
 
    @KanakaKumar @jackylk @QiangCai @ajantha-bhat @kunal642 Rebased, Please review it.


---

[qiuchenjian-2]

Github user ajantha-bhat commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2899#discussion_r241311890
 
    --- Diff: docs/csdk-guide.md ---
    @@ -214,6 +226,122 @@ release the memory and destroy JVM.
         void withHadoopConf(char *key, char *value);
     ```
     
    +<<<<<<< HEAD
    --- End diff --
   
    what's this?
   
    problem while resolving a conflict? please check and redo this file.


---

[qiuchenjian-2]

Github user ajantha-bhat commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2899#discussion_r241313087
 
    --- Diff: docs/csdk-guide.md ---
    @@ -214,6 +226,122 @@ release the memory and destroy JVM.
         void withHadoopConf(char *key, char *value);
     ```
     
    +<<<<<<< HEAD
    +=======
    +```
    + /**
    +     *  To support the table properties for writer
    +     *
    +     * @param key properties key
    +     * @param value properties value
    +     */
    +    void withTableProperty(char *key, char *value);
    +```
    +
    +```
    +    /**
    +     * To support the load options for C++ sdk writer
    +     *
    +     * @param options key,value pair of load options.
    +     * supported keys values are
    +     * a. bad_records_logger_enable -- true (write into separate logs), false
    +     * b. bad_records_action -- FAIL, FORCE, IGNORE, REDIRECT
    +     * c. bad_record_path -- path
    +     * d. dateformat -- same as JAVA SimpleDateFormat
    +     * e. timestampformat -- same as JAVA SimpleDateFormat
    +     * f. complex_delimiter_level_1 -- value to Split the complexTypeData
    +     * g. complex_delimiter_level_2 -- value to Split the nested complexTypeData
    +     * h. quotechar
    +     * i. escapechar
    +     *
    +     * Default values are as follows.
    +     *
    +     * a. bad_records_logger_enable -- "false"
    +     * b. bad_records_action -- "FAIL"
    +     * c. bad_record_path -- ""
    +     * d. dateformat -- "" , uses from carbon.properties file
    +     * e. timestampformat -- "", uses from carbon.properties file
    +     * f. complex_delimiter_level_1 -- "$"
    +     * g. complex_delimiter_level_2 -- ":"
    +     * h. quotechar -- "\""
    +     * i. escapechar -- "\\"
    +     *
    +     * @return updated CarbonWriterBuilder
    +     */
    +    void withLoadOption(char *key, char *value);
    +```
    +
    +```
    +    /**
    +     * sets the taskNo for the writer. CSDKs concurrently running
    +     * will set taskNo in order to avoid conflicts in file's name during write.
    +     *
    +     * @param taskNo is the TaskNo user wants to specify.
    +     *               by default it is system time in nano seconds.
    +     */
    +    void taskNo(long taskNo);
    +```
    +
    +```
    +    /**
    +     * to set the timestamp in the carbondata and carbonindex index files
    +     *
    +     * @param timestamp is a timestamp to be used in the carbondata and carbonindex index files.
    +     * By default set to zero.
    +     * @return updated CarbonWriterBuilder
    +     */
    +    void uniqueIdentifier(long timestamp);
    +```
    +
    +```
    +    /**
    +     * To make c++ sdk writer thread safe.
    +     *
    +     * @param numOfThreads should number of threads in which writer is called in multi-thread scenario
    +     *                      default C++ sdk writer is not thread safe.
    +     *                      can use one writer instance in one thread only.
    +     */
    +    void withThreadSafe(short numOfThreads) ;
    +```
    +
    +```
    +    /**
    +     * To set the carbondata file size in MB between 1MB-2048MB
    +     *
    +     * @param blockSize is size in MB between 1MB to 2048 MB
    +     * default value is 1024 MB
    +     */
    +    void withBlockSize(int blockSize);
    +```
    +
    +```
    +    /**
    +     * To set the blocklet size of CarbonData file
    +     *
    +     * @param blockletSize is blocklet size in MB
    +     *        default value is 64 MB
    +     * @return updated CarbonWriterBuilder
    +     */
    +    void withBlockletSize(int blockletSize);
    +```
    +
    +```
    +    /**
    +     * @param localDictionaryThreshold is localDictionaryThreshold, default is 10000
    +     * @return updated CarbonWriterBuilder
    +     */
    +    void localDictionaryThreshold(int localDictionaryThreshold);
    +```
    +
    +```
    +    /**
    +     * @param enableLocalDictionary enable local dictionary, default is false
    +     * @return updated CarbonWriterBuilder
    +     */
    +    void enableLocalDictionary(bool enableLocalDictionary);
    +```
    +
    +>>>>>>> aebd066bc... [CARBONDATA-3073] Support configure TableProperties,withLoadOption etc. interface in carbon writer of C++ SDK
    --- End diff --
   
    same as above


---

[qiuchenjian-2]

Github user ajantha-bhat commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2899#discussion_r241315209
 
    --- Diff: store/CSDK/src/CarbonWriter.cpp ---
    @@ -58,6 +58,35 @@ void CarbonWriter::outputPath(char *path) {
         carbonWriterBuilderObject = jniEnv->CallObjectMethodA(carbonWriterBuilderObject, methodID, args);
     }
     
    +void CarbonWriter::sortBy(int argc, char **argv) {
    +    if (argc < 0) {
    +        throw std::runtime_error("argc parameter can't be negative.");
    +    }
    +    if (argv == NULL) {
    +        throw std::runtime_error("argv parameter can't be NULL.");
    +    }
    +    checkBuilder();
    +    jclass carbonReaderBuilderClass = jniEnv->GetObjectClass(carbonWriterBuilderObject);
    --- End diff --
   
    it is writerBuilder, not readerBuilder


---