[GitHub] carbondata pull request #2919: [CARBONDATA-3097] Support folder path in getV...

classic Classic list List threaded Threaded
54 messages Options
123
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2919: [CARBONDATA-3097] Support folder path in getV...

qiuchenjian-2
GitHub user xubo245 opened a pull request:

    https://github.com/apache/carbondata/pull/2919

    [CARBONDATA-3097] Support folder path in getVersionDetails and support getVersionDetails in CSDK

    This PR support folder path in getVersionDetails and support getVersionDetails in CSDK
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     add
     - [ ] Any backward compatibility impacted?
     no
     - [ ] Document update required?
    Yes
     - [ ] Testing done
         add test case in SDK and CSDK
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    JIRA2951


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xubo245/carbondata CARBONDATA-3097_getVersionDetails

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2919.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2919
   
----
commit 22a6bd39e63040761b70fc944a056d9492e5e95e
Author: xubo245 <xubo29@...>
Date:   2018-11-14T09:03:17Z

    [CARBONDATA-3097] Support folder path in getVersionDetails and support getVersionDetails in CSDK

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2919: [CARBONDATA-3097] Support folder path in getVersionD...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2919
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1402/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2919: [CARBONDATA-3097] Support folder path in getVersionD...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2919
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1612/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2919: [CARBONDATA-3097] Support folder path in getVersionD...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2919
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9660/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2919: [CARBONDATA-3097] Support folder path in getVersionD...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2919
 
    @KanakaKumar @jackylk @ajantha-bhat @kunal642 Please review it.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2919: [CARBONDATA-3097] Support folder path in getVersionD...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2919
 
    @KanakaKumar @jackylk @QiangCai @ajantha-bhat Please review it.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2919: [CARBONDATA-3097] Support folder path in getVersionD...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2919
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1504/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2919: [CARBONDATA-3097] Support folder path in getVersionD...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2919
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9760/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2919: [CARBONDATA-3097] Support folder path in getVersionD...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2919
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1712/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2919: [CARBONDATA-3097] Support folder path in getVersionD...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2919
 
    @KanakaKumar @jackylk @QiangCai @ajantha-bhat @kunal642 Rebased, Please review it.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2919: [CARBONDATA-3097] Support folder path in getVersionD...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2919
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1619/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2919: [CARBONDATA-3097] Support folder path in getVersionD...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2919
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9879/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2919: [CARBONDATA-3097] Support folder path in getVersionD...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2919
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1830/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2919: [CARBONDATA-3097] Support folder path in getVersionD...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2919
 
    retest this please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2919: [CARBONDATA-3097] Support folder path in getVersionD...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2919
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1625/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2919: [CARBONDATA-3097] Support folder path in getVersionD...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2919
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9885/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2919: [CARBONDATA-3097] Support folder path in getVersionD...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2919
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1836/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2919: [CARBONDATA-3097] Support folder path in getVersionD...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2919
 
    Rebased and CI pass,@KanakaKumar @jackylk @QiangCai @ajantha-bhat @kunal642 Please review it.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2919: [CARBONDATA-3097] Support folder path in getV...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user KanakaKumar commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2919#discussion_r242035462
 
    --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java ---
    @@ -241,12 +241,52 @@ private static Schema readSchemaFromIndexFile(String indexFilePath) throws IOExc
     
       /**
        * This method return the version details in formatted string by reading from carbondata file
    +   * If validate is true, it will check the version details between different carbondata files.
    +   * And if version details are not the same, it will throw exception
        *
    -   * @param dataFilePath
    -   * @return
    +   * @param path     carbondata file path or folder path
    +   * @param validate whether validate the version details between different carbondata files.
    +   * @return string with information of who has written this file
    +   * in which carbondata project version
        * @throws IOException
        */
    -  public static String getVersionDetails(String dataFilePath) throws IOException {
    +  public static String getVersionDetails(String path, boolean validate) throws IOException {
    --- End diff --
   
    I think it is not correct to validate readability through version details. In general new version jars can read all old version files.
   
    Please remove this method.
   



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2919: [CARBONDATA-3097] Support folder path in getV...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2919#discussion_r242429609
 
    --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java ---
    @@ -241,12 +241,52 @@ private static Schema readSchemaFromIndexFile(String indexFilePath) throws IOExc
     
       /**
        * This method return the version details in formatted string by reading from carbondata file
    +   * If validate is true, it will check the version details between different carbondata files.
    +   * And if version details are not the same, it will throw exception
        *
    -   * @param dataFilePath
    -   * @return
    +   * @param path     carbondata file path or folder path
    +   * @param validate whether validate the version details between different carbondata files.
    +   * @return string with information of who has written this file
    +   * in which carbondata project version
        * @throws IOException
        */
    -  public static String getVersionDetails(String dataFilePath) throws IOException {
    +  public static String getVersionDetails(String path, boolean validate) throws IOException {
    --- End diff --
   
    ok, done


---
123