[GitHub] carbondata pull request #2924: [CARBONDATA-3065]Correct the error message fo...

[qiuchenjian-2]

GitHub user brijoobopanna opened a pull request:

    https://github.com/apache/carbondata/pull/2924

    [CARBONDATA-3065]Correct the error message for inverted index columns and update the docment

    Changes in this PR:
    1. Modified the error message when column present in Inverted index is not present in Schema
    2. Updated the table property in user document
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [NA] Any interfaces changed?
     
     - [NA] Any backward compatibility impacted?
     
     - [Yes] Document update required?
   
     - [Yes] Testing done through UT
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [NA] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/brijoobopanna/carbondata error

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2924.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2924
   
----
commit 8444290ebacb85789238f2372a32ccf69467b9a1
Author: brijoobopanna <brijoobopanna@...>
Date:   2018-11-15T05:26:15Z

    correct the error message for inverted index columns and update the document

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2924
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1414/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2924
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1624/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2924
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9672/



---

[qiuchenjian-2]

Github user kunal642 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2924#discussion_r234093857
 
    --- Diff: integration/spark-datasource/src/test/scala/org/apache/spark/sql/carbondata/datasource/SparkCarbonDataSourceTest.scala ---
    @@ -1345,6 +1345,15 @@ class SparkCarbonDataSourceTest extends FunSuite with BeforeAndAfterAll {
         spark.sql("drop table if exists fileformat_drop_hive")
       }
     
    +  test("validate the columns not present in schema") {
    +    spark.sql("drop table if exists validate")
    --- End diff --
   
    Need to drop table after test case completion. better to add in afterAll() too


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2924
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1444/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2924
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9702/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2924
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1654/



---

[qiuchenjian-2]

Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/2924
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2924


---