[GitHub] carbondata pull request #2925: [CARBONDATA-3102] Fix NoClassDefFoundError wh...

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2925
 
    @kunal642 @jackylk Please review it.


---

[qiuchenjian-2]

Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/2925
 
    @xubo245 I dont think we are supporting thriftServer to be run through IntelliJ on local. In cluster mode this jar would already be available as part of spark dependency.
    For SDK because it is dependent on all modules therefore httpclient is required.
   
    @manishgupta88 @kumarvishal09 @jackylk @ravipesala What are your opinions?


---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2925
 
    @kunal642 In cluster, it also has this problem.


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2925#discussion_r241736214
 
    --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/thriftserver/CarbonThriftServer.scala ---
    @@ -48,8 +48,13 @@ object CarbonThriftServer {
           System.exit(0)
         }
     
    +    val master = Option(System.getProperty("spark.master"))
    --- End diff --
   
    I think better to let user give --master local, user can control this.


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2925#discussion_r241736440
 
    --- Diff: integration/spark2/pom.xml ---
    @@ -134,6 +134,11 @@
             </exclusion>
           </exclusions>
         </dependency>
    +    <dependency>
    --- End diff --
   
    I have never encounter this problem before, can you describe the scenario in more detail, in what case NoClassDefFoundError will be thrown?


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2925#discussion_r241774500
 
    --- Diff: integration/spark2/pom.xml ---
    @@ -134,6 +134,11 @@
             </exclusion>
           </exclusions>
         </dependency>
    +    <dependency>
    --- End diff --
   
    I see `org.apache.httpcomponents` is already introduced in other modules, please unify the version for this jar in all places


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2925#discussion_r241802106
 
    --- Diff: integration/spark2/pom.xml ---
    @@ -134,6 +134,11 @@
             </exclusion>
           </exclusions>
         </dependency>
    +    <dependency>
    --- End diff --
   
    ok, done


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2925#discussion_r241802156
 
    --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/thriftserver/CarbonThriftServer.scala ---
    @@ -48,8 +48,13 @@ object CarbonThriftServer {
           System.exit(0)
         }
     
    +    val master = Option(System.getProperty("spark.master"))
    --- End diff --
   
    ok, done


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2925
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1770/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2925
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1983/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2925
 
    Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10030/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2925
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2925


---