[GitHub] carbondata pull request #2931: [CARBONDATA-2999] support read schema from S3

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2931
 
    rebase and fix the conflict


---

[qiuchenjian-2]

Github user KanakaKumar commented on the issue:

    https://github.com/apache/carbondata/pull/2931
 
    LGTM


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2931
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1816/



---

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2931#discussion_r242428274
 
    --- Diff: store/CSDK/test/main.cpp ---
    @@ -822,16 +831,17 @@ int main(int argc, char *argv[]) {
         // init jvm
         JNIEnv *env;
         env = initJVM();
    -    char *S3WritePath = "s3a://csdk/WriterOutput/carbondata2";
    -    char *S3ReadPath = "s3a://csdk/WriterOutput/carbondata";
    +    char *S3WritePath = "s3a://xubo/WriterOutput/carbondata2";
    --- End diff --
   
    please change the path


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2931
 
    Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10075/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2931
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1819/



---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2931#discussion_r242444376
 
    --- Diff: store/CSDK/test/main.cpp ---
    @@ -822,16 +831,17 @@ int main(int argc, char *argv[]) {
         // init jvm
         JNIEnv *env;
         env = initJVM();
    -    char *S3WritePath = "s3a://csdk/WriterOutput/carbondata2";
    -    char *S3ReadPath = "s3a://csdk/WriterOutput/carbondata";
    +    char *S3WritePath = "s3a://xubo/WriterOutput/carbondata2";
    --- End diff --
   
    OK，done


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2931
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2028/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2931
 
    Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10077/



---

[qiuchenjian-2]

Github user QiangCai commented on the issue:

    https://github.com/apache/carbondata/pull/2931
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2931


---