[GitHub] carbondata pull request #2935: [HOTFIX] Intializing the CSDK object referenc...

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2935: [HOTFIX] Intializing the CSDK object referenc...

qiuchenjian-2
GitHub user brijoobopanna opened a pull request:

    https://github.com/apache/carbondata/pull/2935

    [HOTFIX] Intializing the CSDK object reference to NULL

    Changes in this PR:
   
    NULL intialization done to JObjects in CPP files of CSDK. This prevents seg fault when these objects are referenced without initilization .
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [NA] Any interfaces changed?
     
     - [NA] Any backward compatibility impacted?
     
     - [NA] Document update required?
   
     - [OK] Testing done using existing test cases
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ NA] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/brijoobopanna/carbondata master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2935.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2935
   
----
commit e794edd961431c0f6f7d62abc06d766e82da0d97
Author: brijoobopanna <brijoobopanna@...>
Date:   2018-11-20T13:29:54Z

    Intializing the CSDK files

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2935: [HOTFIX] Intializing the CSDK object reference to NU...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2935
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1466/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2935: [HOTFIX] Intializing the CSDK object reference to NU...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user BJangir commented on the issue:

    https://github.com/apache/carbondata/pull/2935
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2935: [HOTFIX] Intializing the CSDK object reference to NU...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2935
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9724/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2935: [HOTFIX] Intializing the CSDK object reference to NU...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2935
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1676/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2935: [HOTFIX] Intializing the CSDK object reference to NU...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user brijoobopanna commented on the issue:

    https://github.com/apache/carbondata/pull/2935
 
    retest this please



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2935: [HOTFIX] Intializing the CSDK object reference to NU...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2935
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1471/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2935: [HOTFIX] Intializing the CSDK object reference to NU...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2935
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1681/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2935: [HOTFIX] Intializing the CSDK object reference to NU...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2935
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9729/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2935: [HOTFIX] Intializing the CSDK object reference to NU...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/2935
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2935: [HOTFIX] Intializing the CSDK object referenc...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2935


---