[GitHub] carbondata pull request #2948: [CARBONDATA-3124] Updated log message in Unsa...

[qiuchenjian-2]

GitHub user shardul-cr7 opened a pull request:

    https://github.com/apache/carbondata/pull/2948

    [CARBONDATA-3124] Updated log message in UnsafeMemoryManager

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shardul-cr7/carbondata 23-nov

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2948.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2948
   
----
commit c19d454f4dcf95b82754fe05c3eb2df06d98fe33
Author: shardul-cr7 <shardulsingh22@...>
Date:   2018-11-23T13:15:44Z

    [CARBONDATA-3124] Updated log message in UnsafeMemoryManager

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2948
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1525/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2948
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1735/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2948
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9783/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2948
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1542/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2948
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9801/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2948
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1753/



---

[qiuchenjian-2]

Github user praveenmeenakshi56 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2948#discussion_r236992267
 
    --- Diff: docs/faq.md ---
    @@ -216,20 +216,18 @@ TimeZone.setDefault(TimeZone.getTimeZone("Asia/Shanghai"))
     ## How to check LRU cache memory footprint?
     To observe the LRU cache memory footprint in the logs, configure the below properties in log4j.properties file.
     ```
    -log4j.logger.org.apache.carbondata.core.memory.UnsafeMemoryManager = DEBUG
     log4j.logger.org.apache.carbondata.core.cache.CarbonLRUCache = DEBUG
     ```
    -These properties will enable the DEBUG log for the CarbonLRUCache and UnsafeMemoryManager which will print the information of memory consumed using which the LRU cache size can be decided. **Note:** Enabling the DEBUG log will degrade the query performance.
    +This properties will enable the DEBUG log for the CarbonLRUCache and UnsafeMemoryManager which will print the information of memory consumed using which the LRU cache size can be decided. **Note:** Enabling the DEBUG log will degrade the query performance. Ensure carbon.max.driver.lru.cache.size is configured to observe the current cache size.
    --- End diff --
   
    These is the correct usage. Revert back to the same


---

[qiuchenjian-2]

Github user shardul-cr7 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2948#discussion_r236998844
 
    --- Diff: docs/faq.md ---
    @@ -216,20 +216,18 @@ TimeZone.setDefault(TimeZone.getTimeZone("Asia/Shanghai"))
     ## How to check LRU cache memory footprint?
     To observe the LRU cache memory footprint in the logs, configure the below properties in log4j.properties file.
     ```
    -log4j.logger.org.apache.carbondata.core.memory.UnsafeMemoryManager = DEBUG
     log4j.logger.org.apache.carbondata.core.cache.CarbonLRUCache = DEBUG
     ```
    -These properties will enable the DEBUG log for the CarbonLRUCache and UnsafeMemoryManager which will print the information of memory consumed using which the LRU cache size can be decided. **Note:** Enabling the DEBUG log will degrade the query performance.
    +This properties will enable the DEBUG log for the CarbonLRUCache and UnsafeMemoryManager which will print the information of memory consumed using which the LRU cache size can be decided. **Note:** Enabling the DEBUG log will degrade the query performance. Ensure carbon.max.driver.lru.cache.size is configured to observe the current cache size.
    --- End diff --
   
    Actually we are now just showing one log for CarbonLRUCache.So *these* is is not correct usage. I'll change properties to property.


---

[qiuchenjian-2]

Github user shardul-cr7 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2948#discussion_r237000628
 
    --- Diff: docs/faq.md ---
    @@ -216,20 +216,18 @@ TimeZone.setDefault(TimeZone.getTimeZone("Asia/Shanghai"))
     ## How to check LRU cache memory footprint?
     To observe the LRU cache memory footprint in the logs, configure the below properties in log4j.properties file.
     ```
    -log4j.logger.org.apache.carbondata.core.memory.UnsafeMemoryManager = DEBUG
     log4j.logger.org.apache.carbondata.core.cache.CarbonLRUCache = DEBUG
     ```
    -These properties will enable the DEBUG log for the CarbonLRUCache and UnsafeMemoryManager which will print the information of memory consumed using which the LRU cache size can be decided. **Note:** Enabling the DEBUG log will degrade the query performance.
    +This properties will enable the DEBUG log for the CarbonLRUCache and UnsafeMemoryManager which will print the information of memory consumed using which the LRU cache size can be decided. **Note:** Enabling the DEBUG log will degrade the query performance. Ensure carbon.max.driver.lru.cache.size is configured to observe the current cache size.
    --- End diff --
   
    Done!



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2948
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1568/



---

[qiuchenjian-2]

Github user praveenmeenakshi56 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2948#discussion_r237020151
 
    --- Diff: docs/faq.md ---
    @@ -216,20 +216,18 @@ TimeZone.setDefault(TimeZone.getTimeZone("Asia/Shanghai"))
     ## How to check LRU cache memory footprint?
     To observe the LRU cache memory footprint in the logs, configure the below properties in log4j.properties file.
     ```
    -log4j.logger.org.apache.carbondata.core.memory.UnsafeMemoryManager = DEBUG
     log4j.logger.org.apache.carbondata.core.cache.CarbonLRUCache = DEBUG
     ```
    -These properties will enable the DEBUG log for the CarbonLRUCache and UnsafeMemoryManager which will print the information of memory consumed using which the LRU cache size can be decided. **Note:** Enabling the DEBUG log will degrade the query performance.
    +This properties will enable the DEBUG log for the CarbonLRUCache and UnsafeMemoryManager which will print the information of memory consumed using which the LRU cache size can be decided. **Note:** Enabling the DEBUG log will degrade the query performance. Ensure carbon.max.driver.lru.cache.size is configured to observe the current cache size.
    --- End diff --
   
    +1


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2948
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9827/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2948
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1779/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2948
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2948


---