[GitHub] carbondata pull request #2949: [WIP] support parallel block pruning for non-...

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2949#discussion_r241279768
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/dev/DataMap.java ---
    @@ -70,4 +70,8 @@ void init(DataMapModel dataMapModel)
        */
       void finish();
     
    +  /*
    +  * Returns number of records information that are stored in datamap.
    +  * */
    +  int getNumberOfEntries();
    --- End diff --
   
    Add comment here the purpose of this number here.


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2949
 
    @ajantha-bhat Please rebase


---

[qiuchenjian-2]

Github user ajantha-bhat commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2949#discussion_r241737142
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/dev/DataMap.java ---
    @@ -70,4 +70,8 @@ void init(DataMapModel dataMapModel)
        */
       void finish();
     
    +  /*
    +  * Returns number of records information that are stored in datamap.
    +  * */
    +  int getNumberOfEntries();
    --- End diff --
   
    done


---

[qiuchenjian-2]

Github user ajantha-bhat commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2949#discussion_r241737152
 
    --- Diff: datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMap.java ---
    @@ -436,4 +436,9 @@ public String toString() {
       public void finish() {
     
       }
    +
    +  @Override public int getNumberOfEntries() {
    --- End diff --
   
    done


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2949
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1765/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2949
 
    Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10026/



---

[qiuchenjian-2]

Github user ajantha-bhat commented on the issue:

    https://github.com/apache/carbondata/pull/2949
 
    @ravipesala : PR is ready please check.


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2949
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2949


---