[GitHub] carbondata pull request #2959: getOrCreateCarbonSession method parameter is ...

[qiuchenjian-2]

GitHub user zygitup opened a pull request:

    https://github.com/apache/carbondata/pull/2959

    getOrCreateCarbonSession method parameter is an empty string repair[JIRA CARBONDATA-3119]

    1.No interface changes
     
    2.Backward compatibility is not affected
     
    3.The document does not need to be updated
   
    4.
     val carbon = SparkSession.builder().config(sc.getConf).getOrCreateCarbonSession("")
     val carbon = SparkSession.builder().config(sc.getConf).getOrCreateCarbonSession("  ")
     carbon.sql("SELECT * FROM TABLE").show()   is ok.
     
   
   
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zygitup/carbondata master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2959.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2959
   
----
commit 945d0fda4c60ec3300a06d0b71a923a86fd65f2b
Author: zygitup <18310672430@...>
Date:   2018-11-28T08:46:59Z

    integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala  getOrCreateCarbonSession method parameters Filter for null and empty string

commit efc293b8ed3054edfc77002a9a049e34af476ce6
Author: zygitup <18310672430@...>
Date:   2018-11-28T08:48:35Z

    integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala  getOrCreateCarbonSession method parameters Filter for null and empty string

commit b8409583ef6463a070998640451c7158b22a126f
Author: zygitup <18310672430@...>
Date:   2018-11-28T08:53:38Z

    add all

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2959
 
    Can one of the admins verify this patch?


---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2959
 
    Please optimize the title: [CARBONDATA-3119]Fix the error of getOrCreateCarbonSession method parameter is an empty string


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2959#discussion_r237039136
 
    --- Diff: format/pom.xml ---
    @@ -15,58 +15,59 @@
         See the License for the specific language governing permissions and
         limitations under the License.
     -->
    -<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    --- End diff --
   
    no need to change, please keep the original format


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2959#discussion_r237039260
 
    --- Diff: integration/presto/Presto_Cluster_Setup_For_Carbondata.md ---
    @@ -1,135 +0,0 @@
    -# Presto Multinode Cluster setup For Carbondata
    --- End diff --
   
    Why do you remove it?


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2959#discussion_r237039377
 
    --- Diff: pom.xml ---
    @@ -614,7 +614,7 @@
           <modules>
             <module>integration/spark2</module>
             <module>integration/hive</module>
    -        <module>integration/presto</module>
    +        <!--<module>integration/presto</module>-->
    --- End diff --
   
    no need to change, please keep the original format


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2959#discussion_r237039395
 
    --- Diff: pom.xml ---
    @@ -556,7 +556,7 @@
           <modules>
             <module>integration/spark2</module>
             <module>integration/hive</module>
    -        <module>integration/presto</module>
    +        <!--<module>integration/presto</module>-->
    --- End diff --
   
    no need to change, please keep the original format


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2959#discussion_r237039483
 
    --- Diff: pom.xml ---
    @@ -496,7 +496,7 @@
           <modules>
             <module>integration/spark2</module>
             <module>integration/hive</module>
    -        <module>integration/presto</module>
    +        <!--<module>integration/presto</module>-->
    --- End diff --
   
    no need to change, please keep the original format


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2959#discussion_r237039520
 
    --- Diff: pom.xml ---
    @@ -463,7 +463,7 @@
             <module>integration/spark2</module>
             <module>examples/spark2</module>
             <module>integration/hive</module>
    -        <module>integration/presto</module>
    +        <!--<module>integration/presto</module>-->
    --- End diff --
   
    no need to change, please keep the original format


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2959#discussion_r237039594
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala ---
    @@ -269,9 +271,9 @@ object CarbonSession {
           session
         }
     
    -    /**
    -     * It is a hack to get the private field from class.
    -     */
    +     /**
    --- End diff --
   
    no need to change, please keep the original format


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2959#discussion_r237039659
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala ---
    @@ -171,7 +173,7 @@ object CarbonSession {
         }
     
         def getOrCreateCarbonSession(storePath: String,
    -        metaStorePath: String): SparkSession = synchronized {
    +                                 metaStorePath: String): SparkSession = synchronized {
    --- End diff --
   
    no need to change, please keep the original format


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2959#discussion_r237039728
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala ---
    @@ -114,8 +115,8 @@ class CarbonSession(@transient val sc: SparkContext,
       }
     
       private def withProfiler(
    -      sqlText: String,
    -      generateDF: (QueryExecution, SQLStart) => DataFrame): DataFrame = {
    +                            sqlText: String,
    --- End diff --
   
    no need to change, please keep the original format


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2959#discussion_r237039743
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala ---
    @@ -80,32 +81,32 @@ class CarbonSession(@transient val sc: SparkContext,
         new CarbonSession(sparkContext, Some(sharedState), useHiveMetaStore)
       }
     
    -  /**
    -   * Run search mode if enabled, otherwise run SparkSQL
    -   */
    +   /**
    +    * Run search mode if enabled, otherwise run SparkSQL
    +    */
       override def sql(sqlText: String): DataFrame = {
         withProfiler(
           sqlText,
           (qe, sse) => {
    -          new Dataset[Row](self, qe, RowEncoder(qe.analyzed.schema))
    +        new Dataset[Row](self, qe, RowEncoder(qe.analyzed.schema))
           }
         )
       }
     
    -  /**
    -   * Return true if the specified sql statement will hit the datamap
    -   * This API is for test purpose only
    -   */
    +   /**
    +    * Return true if the specified sql statement will hit the datamap
    +    * This API is for test purpose only
    +    */
       @InterfaceAudience.Developer(Array("DataMap"))
       def isDataMapHit(sqlStatement: String, dataMapName: String): Boolean = {
         // explain command will output the dataMap information only if enable.query.statistics = true
         val message = sql(s"EXPLAIN $sqlStatement").collect()
         message(0).getString(0).contains(dataMapName)
       }
     
    -  /**
    -   * Run SparkSQL directly
    -   */
    +   /**
    --- End diff --
   
    no need to change, please keep the original format


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2959#discussion_r237039754
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala ---
    @@ -80,32 +81,32 @@ class CarbonSession(@transient val sc: SparkContext,
         new CarbonSession(sparkContext, Some(sharedState), useHiveMetaStore)
       }
     
    -  /**
    -   * Run search mode if enabled, otherwise run SparkSQL
    -   */
    +   /**
    +    * Run search mode if enabled, otherwise run SparkSQL
    +    */
       override def sql(sqlText: String): DataFrame = {
         withProfiler(
           sqlText,
           (qe, sse) => {
    -          new Dataset[Row](self, qe, RowEncoder(qe.analyzed.schema))
    +        new Dataset[Row](self, qe, RowEncoder(qe.analyzed.schema))
           }
         )
       }
     
    -  /**
    -   * Return true if the specified sql statement will hit the datamap
    -   * This API is for test purpose only
    -   */
    +   /**
    --- End diff --
   
    no need to change, please keep the original format


---

[qiuchenjian-2]

Github user zygitup closed the pull request at:

    https://github.com/apache/carbondata/pull/2959


---