[GitHub] carbondata pull request #2961: Fixing the getOrCreateCarbonSession method pa...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2961
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1601/



---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2961#discussion_r237782459
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala ---
    @@ -180,7 +183,7 @@ object CarbonSession {
           val userSuppliedContext: Option[SparkContext] =
             getValue("userSuppliedContext", builder).asInstanceOf[Option[SparkContext]]
     
    -      if (metaStorePath != null) {
    +      if (metaStorePath != null && StringUtils.isNotBlank(metaStorePath)) {
    --- End diff --
   
    StringUtils.isNotBlank will judge null


---

[qiuchenjian-2]

Github user zzcclp commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2961#discussion_r237782924
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala ---
    @@ -37,6 +38,8 @@ import org.apache.carbondata.core.constants.CarbonCommonConstants
     import org.apache.carbondata.core.util.{CarbonProperties, CarbonSessionInfo, ThreadLocalSessionInfo}
     import org.apache.carbondata.streaming.CarbonStreamingQueryListener
     
    +
    +
    --- End diff --
   
    remove these two lines.


---

[qiuchenjian-2]

Github user zzcclp commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2961#discussion_r237783794
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala ---
    @@ -248,7 +251,7 @@ object CarbonSession {
     
             session = new CarbonSession(sparkContext, None, !enableInMemCatlog)
             val carbonProperties = CarbonProperties.getInstance()
    -        if (storePath != null) {
    +        if (storePath != null && StringUtils.isNotBlank(storePath)) {
    --- End diff --
   
    remove 'storePath != null', StringUtils.isNotBlank already includes this judgement.


---

[qiuchenjian-2]

Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/2961
 
    If possible, it better add a test case for this.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2961
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9861/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2961
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1812/



---

[qiuchenjian-2]

Github user zygitup commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2961#discussion_r237807538
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala ---
    @@ -37,6 +38,8 @@ import org.apache.carbondata.core.constants.CarbonCommonConstants
     import org.apache.carbondata.core.util.{CarbonProperties, CarbonSessionInfo, ThreadLocalSessionInfo}
     import org.apache.carbondata.streaming.CarbonStreamingQueryListener
     
    +
    +
    --- End diff --
   
    ok.Has been removed


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2961
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1603/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2961
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9863/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2961
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1814/



---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2961
 
    LGTM


---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2961
 
    LGTM


---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2961
 
    LGTM


---

[qiuchenjian-2]

Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/2961
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2961


---