[GitHub] carbondata pull request #2964: [HOTFIX] Fix ArrayOutOfBound exception when d...

[qiuchenjian-2]

GitHub user ajantha-bhat opened a pull request:

    https://github.com/apache/carbondata/pull/2964

    [HOTFIX] Fix ArrayOutOfBound exception when duplicate measure in projection column

    problem: ArrayOutOfBound exception when duplicate measure in the projection column
   
    cause: In query executor, when the reusable buffer is formed. It was considering only the unique values. Need to consider all the projections.
   
    solution: consider all the projections, while forming a reusable buffer.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed? NA
     
     - [ ] Any backward compatibility impacted? NA
     
     - [ ] Document update required? NA
   
     - [ ] Testing done
            yes, updated UT.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.  NA
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ajantha-bhat/carbondata sdk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2964.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2964
   
----
commit ca6fd01b92844f43f2472ccf3f17d498bbd73216
Author: ajantha-bhat <ajanthabhat@...>
Date:   2018-11-29T11:42:56Z

    fix ArrayOutOfBound exception when duplicate measure in projection column

----


---

[qiuchenjian-2]

Github user ajantha-bhat commented on the issue:

    https://github.com/apache/carbondata/pull/2964
 
    @kunal642 , @kumarvishal09 : please check this


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2964
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1582/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2964
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1583/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2964
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9842/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2964
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1795/



---

[qiuchenjian-2]

Github user qiuchenjian commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2964#discussion_r237505549
 
    --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java ---
    @@ -575,7 +575,7 @@ public void testReadColumnTwice() throws IOException, InterruptedException {
     
         CarbonReader reader = CarbonReader
             .builder(path, "_temp")
    -        .projection(new String[]{"name", "name", "age", "name"})
    +        .projection(new String[]{"name", "age", "age", "name"})
    --- End diff --
   
    the types of four columns are all String, this skip the measure part. I think another test is needed, which columns has int or short or long type


---

[qiuchenjian-2]

Github user ajantha-bhat commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2964#discussion_r237548880
 
    --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java ---
    @@ -575,7 +575,7 @@ public void testReadColumnTwice() throws IOException, InterruptedException {
     
         CarbonReader reader = CarbonReader
             .builder(path, "_temp")
    -        .projection(new String[]{"name", "name", "age", "name"})
    +        .projection(new String[]{"name", "age", "age", "name"})
    --- End diff --
   
    @qiuchenjian : NO, age is an int column (measure), check schema in writer buildler.
   
    No need of new test case, now this test case handle testing duplicate measures and dimensions.


---

[qiuchenjian-2]

Github user qiuchenjian commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2964#discussion_r237715058
 
    --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java ---
    @@ -575,7 +575,7 @@ public void testReadColumnTwice() throws IOException, InterruptedException {
     
         CarbonReader reader = CarbonReader
             .builder(path, "_temp")
    -        .projection(new String[]{"name", "name", "age", "name"})
    +        .projection(new String[]{"name", "age", "age", "name"})
    --- End diff --
   
    OK, I just noticed this  â€œfields[1] = new Field("age", DataTypes.INT);”


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2964
 
    LGTM


---

[qiuchenjian-2]

Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/2964
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2964


---