Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2976#discussion_r240214729
--- Diff: processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerModel.java ---
@@ -407,6 +426,81 @@ public static CarbonFactDataHandlerModel getCarbonFactDataHandlerModel(CarbonLoa
return carbonFactDataHandlerModel;
}
+ /**
+ * This routine takes the Complex Dimension and convert into generic DataType.
+ * @param complexDimensions
+ * @param dimensionCount
+ * @param isNullFormat
+ *@param isEmptyBadRecords @return
+ */
+ private static Map<Integer, GenericDataType> convertComplexDimensionToGenericDataType(
+ List<CarbonDimension> complexDimensions, int dimensionCount, String isNullFormat,
+ boolean isEmptyBadRecords) {
+ Map<Integer, GenericDataType> complexIndexMap =
+ new HashMap<Integer, GenericDataType>(complexDimensions.size());
+
+ for (CarbonDimension carbonDimension : complexDimensions) {
+
+ if (carbonDimension.isComplex()) {
+ GenericDataType g;
+ if (carbonDimension.getColumnSchema().getDataType().getName().equalsIgnoreCase("ARRAY")) {
+ g = new ArrayDataType(carbonDimension.getColName(), "", carbonDimension.getColumnId());
+ } else if (carbonDimension.getColumnSchema().getDataType().getName()
+ .equalsIgnoreCase("STRUCT")) {
+ g = new StructDataType(carbonDimension.getColName(), "", carbonDimension.getColumnId());
+ } else {
+ // Add Primitive type.
+ throw new RuntimeException("Primitive Type should not be coming in first loop");
+ }
+ if (carbonDimension.getNumberOfChild() > 0) {
+ addChildrenForComplex(carbonDimension.getListOfChildDimensions(), g, isNullFormat,
+ isEmptyBadRecords);
+ }
+ g.setOutputArrayIndex(0);
+ complexIndexMap.put(dimensionCount++, g);
+ }
+
+ }
+ return complexIndexMap;
+ }
+
+ private static void addChildrenForComplex(List<CarbonDimension> listOfChildDimensions,
+ GenericDataType genericDataType, String isNullFormat, boolean isEmptyBadRecord) {
+ for (CarbonDimension carbonDimension : listOfChildDimensions) {
+ if (carbonDimension.getColumnSchema().getDataType().getName().equalsIgnoreCase("ARRAY")) {
+ GenericDataType arrayGeneric = new ArrayDataType(carbonDimension.getColName(),
+ carbonDimension.getColName()
+ .substring(0, carbonDimension.getColName().lastIndexOf(".")),
+ carbonDimension.getColumnId());
+ if (carbonDimension.getNumberOfChild() > 0) {
+ addChildrenForComplex(carbonDimension.getListOfChildDimensions(), arrayGeneric,
+ isNullFormat, isEmptyBadRecord);
+ }
+ genericDataType.addChildren(arrayGeneric);
+ } else if (carbonDimension.getColumnSchema().getDataType().getName()
+ .equalsIgnoreCase("STRUCT")) {
+ GenericDataType structGeneric = new StructDataType(carbonDimension.getColName(),
+ carbonDimension.getColName()
+ .substring(0, carbonDimension.getColName().lastIndexOf(".")),
+ carbonDimension.getColumnId());
+ if (carbonDimension.getNumberOfChild() > 0) {
+ addChildrenForComplex(carbonDimension.getListOfChildDimensions(), structGeneric,
+ isNullFormat, isEmptyBadRecord);
+ }
+ genericDataType.addChildren(structGeneric);
+ } else {
+ // Primitive Data Type
+ genericDataType.addChildren(
+ new PrimitiveDataType(carbonDimension.getColumnSchema().getColumnName(),
+ carbonDimension.getDataType(), carbonDimension.getColName()
+ .substring(0, carbonDimension.getColName().lastIndexOf(".")),
+ carbonDimension.getColumnId(),
+ carbonDimension.getColumnSchema().hasEncoding(Encoding.DICTIONARY), isNullFormat,
+ isEmptyBadRecord));
--- End diff --
Please check and remove `isEmptyBadRecord` from it if not used
---
Locked
