[GitHub] carbondata pull request #2979: [CARBONDATA-3153] Complex delimiters change

classic Classic list List threaded Threaded
30 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2979: [CARBONDATA-3153] Complex delimiters change

qiuchenjian-2
GitHub user manishnalla1994 opened a pull request:

    https://github.com/apache/carbondata/pull/2979

    [CARBONDATA-3153] Complex delimiters change

    Changed the two Complex Delimiters used to '\001' and '\002'.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [x] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/manishnalla1994/carbondata ComplexDelimiters

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2979.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2979
   
----
commit 7cfa05fbf65b5b176fe94ce6c36e4deb10a2a437
Author: manishnalla1994 <manish.nalla1994@...>
Date:   2018-12-07T09:25:58Z

    Delimiters changed

commit bcf265316627f49862a994292bb37169afe40403
Author: manishnalla1994 <manish.nalla1994@...>
Date:   2018-12-07T13:46:57Z

    Change of 2 complex delimiters

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2979: [CARBONDATA-3153] Complex delimiters change

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2979
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1656/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2979: [CARBONDATA-3153] Complex delimiters change

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2979
 
    Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9916/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2979: [CARBONDATA-3153] Complex delimiters change

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2979
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1868/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2979: [CARBONDATA-3153] Complex delimiters change

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2979
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1663/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2979: [CARBONDATA-3153] Complex delimiters change

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2979
 
    Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9923/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2979: [CARBONDATA-3153] Complex delimiters change

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2979
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1875/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2979: [CARBONDATA-3153] Complex delimiters change

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2979
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1664/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2979: [CARBONDATA-3153] Complex delimiters change

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2979
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1876/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2979: [CARBONDATA-3153] Complex delimiters change

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2979
 
    Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9924/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2979: [CARBONDATA-3153] Complex delimiters change

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2979
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1679/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2979: [CARBONDATA-3153] Complex delimiters change

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2979
 
    Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9939/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2979: [CARBONDATA-3153] Complex delimiters change

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2979
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1891/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2979: [CARBONDATA-3153] Complex delimiters change

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2979
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1714/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2979: [CARBONDATA-3153] Complex delimiters change

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2979
 
    Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9974/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2979: [CARBONDATA-3153] Complex delimiters change

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2979
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1925/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2979: [CARBONDATA-3153] Complex delimiters change

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2979
 
    @manishnalla1994 Please fix the checkstyle


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2979: [CARBONDATA-3153] Complex delimiters change

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2979
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1736/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2979: [CARBONDATA-3153] Complex delimiters change

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2979
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1948/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2979: [CARBONDATA-3153] Complex delimiters change

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2979
 
    Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9996/



---
12