[GitHub] carbondata pull request #2996: [WIP] Fix Rename-Fail & Datamap-creation-Fail

classic Classic list List threaded Threaded
26 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2996: [WIP] Fix Rename-Fail & Datamap-creation-Fail

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2996
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2416/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2996: [WIP] Fix Rename-Fail & Datamap-creation-Fail

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2996
 
    Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10456/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2996: [CARBONDATA-3235] Fix Rename-Fail & Datamap-c...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user NamanRastogi commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2996#discussion_r245925395
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableRenameCommand.scala ---
    @@ -165,15 +167,22 @@ private[sql] case class CarbonAlterTableRenameCommand(
           case e: ConcurrentOperationException =>
             throw e
           case e: Exception =>
    +        if (hiveRenameSuccess) {
    +          sparkSession.sessionState.catalog.asInstanceOf[CarbonSessionCatalog].alterTableRename(
    --- End diff --
   
    @qiuchenjian
    @kevinjmh Is Correct.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2996: [CARBONDATA-3235] Fix Rename-Fail & Datamap-creation...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/2996
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2996: [CARBONDATA-3235] Fix Rename-Fail & Datamap-creation...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/2996
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2996: [CARBONDATA-3235] Fix Rename-Fail & Datamap-c...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2996


---
12