[GitHub] carbondata pull request #3015: [Carbondata 3173] Add the hive /presto docume...

[qiuchenjian-2]

GitHub user BeyondYourself opened a pull request:

    https://github.com/apache/carbondata/pull/3015

    [Carbondata 3173]  Add the hive /presto documents index to the root of file ReadMe

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/BeyondYourself/carbondata CARBONDATA-3173

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/3015.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3015
   
----
commit d7c1a0ae1d9a6b358fa3e00fc6519043f624db01
Author: BeyondYourself <qq861937180@...>
Date:   2018-12-20T06:39:18Z

    add the hive /presto  /flink /alluxio  documents index  to the root of file ReadMe.md   ，it helps us to find the relevant integration documents

commit 56e095ffde92095de08203b264359e383bb7c824
Author: BeyondYourself <861937180@...>
Date:   2018-12-20T14:32:37Z

    Add the hive /presto   documents index  to the root of file ReadMe.md ,it helps us to find the relevant integration documents

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3015
 
    Can one of the admins verify this patch?


---

[qiuchenjian-2]

Github user BeyondYourself commented on the issue:

    https://github.com/apache/carbondata/pull/3015
 
    @xubo245  hi ,can you take a time to check this pr?


---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/3015
 
    How to handle this doc?
    https://github.com/apache/carbondata/blob/master/integration/presto/Presto_Cluster_Setup_For_Carbondata.md


---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/3015
 
    @BeyondYourself Please finish checklist of PR content.


---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/3015
 
    @chenliang613 @sraghunandan Please review this PR, This. PR add integration for hive and presto, we will add alluxio, flink in the future.


---

[qiuchenjian-2]

Github user sraghunandan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3015#discussion_r243871184
 
    --- Diff: README.md ---
    @@ -67,6 +67,10 @@ CarbonData is built using Apache Maven, to [build CarbonData](https://github.com
     * [Carbon as Spark's Datasource](https://github.com/apache/carbondata/blob/master/docs/carbon-as-spark-datasource-guide.md)
     * [FAQs](https://github.com/apache/carbondata/blob/master/docs/faq.md)
     
    +##  Integrations
    --- End diff --
   
    Need to update in documentation.md and in quick-start-guide.md
    The website carbondata.apache.org picks from these two md files


---

[qiuchenjian-2]

Github user BeyondYourself commented on the issue:

    https://github.com/apache/carbondata/pull/3015
 
    >
    >
    > How to handle this doc?
    > https://github.com/apache/carbondata/blob/master/integration/presto/Presto_Cluster_Setup_For_Carbondata.md. @BeyondYourself
   
    I had ever confused by  the document [https://github.com/apache/carbondata/blob/master/integration/presto/README.md](url) and  [https://github.com/apache/carbondata/blob/master/integration/presto   /Presto_Cluster_Setup_For_Carbondata.md](url),now ,I have get it ,the [https://github.com/apache/carbondata/blob/master/integration/presto   /Presto_Cluster_Setup_For_Carbondata.md](url) should be add the link to the root of ReadMe.md


---

[qiuchenjian-2]

Github user BeyondYourself commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3015#discussion_r243873037
 
    --- Diff: README.md ---
    @@ -67,6 +67,10 @@ CarbonData is built using Apache Maven, to [build CarbonData](https://github.com
     * [Carbon as Spark's Datasource](https://github.com/apache/carbondata/blob/master/docs/carbon-as-spark-datasource-guide.md)
     * [FAQs](https://github.com/apache/carbondata/blob/master/docs/faq.md)
     
    +##  Integrations
    --- End diff --
   
    OK, I will update the documents at soon


---

[qiuchenjian-2]

Github user BeyondYourself commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3015#discussion_r243877285
 
    --- Diff: README.md ---
    @@ -67,6 +67,10 @@ CarbonData is built using Apache Maven, to [build CarbonData](https://github.com
     * [Carbon as Spark's Datasource](https://github.com/apache/carbondata/blob/master/docs/carbon-as-spark-datasource-guide.md)
     * [FAQs](https://github.com/apache/carbondata/blob/master/docs/faq.md)
     
    +##  Integrations
    --- End diff --
   
    @sraghunandan  I have  updated the  relevant documents : documentation.md and in quick-start-guide.md, please check it if you have free time


---

[qiuchenjian-2]

Github user sraghunandan commented on the issue:

    https://github.com/apache/carbondata/pull/3015
 
    LGTM


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3015#discussion_r244100329
 
    --- Diff: docs/quick-start-guide.md ---
    @@ -461,3 +464,82 @@ select * from carbon_table;
     
     **Note :** Create Tables and data loads should be done before executing queries as we can not create carbon table from this interface.
     
    +## Installing and Configuring CarbonData on Hive
    +### Build (In 1.2.0, hive integration only support spark2.1 and hadoop2.7.2)
    --- End diff --
   
    I think we should add one more in here, because it will difficult to maintain for it.
     I suggest you only add a link for it in here, it's enough.


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3015#discussion_r244100634
 
    --- Diff: README.md ---
    @@ -67,6 +67,10 @@ CarbonData is built using Apache Maven, to [build CarbonData](https://github.com
     * [Carbon as Spark's Datasource](https://github.com/apache/carbondata/blob/master/docs/carbon-as-spark-datasource-guide.md)
     * [FAQs](https://github.com/apache/carbondata/blob/master/docs/faq.md)
     
    +##  Integrations
    +* [Hive](https://github.com/apache/carbondata/blob/master/docs/hive-guide.md)
    +* [Presto](https://github.com/apache/carbondata/blob/master/integration/presto/Presto_Cluster_Setup_For_Carbondata.md)
    --- End diff --
   
    Can you move the doc to docs folder?


---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/3015
 
    > > How to handle this doc?
    > > https://github.com/apache/carbondata/blob/master/integration/presto/Presto_Cluster_Setup_For_Carbondata.md. @BeyondYourself
    >
    > I had ever confused by the document [https://github.com/apache/carbondata/blob/master/integration/presto/README.md](url) and [https://github.com/apache/carbondata/blob/master/integration/presto /Presto_Cluster_Setup_For_Carbondata.md](url),now ,I have get it ,the [https://github.com/apache/carbondata/blob/master/integration/presto /Presto_Cluster_Setup_For_Carbondata.md](url) should be add the link to the root of ReadMe.md
   
    I think README.md is for single node,  Presto_Cluster_Setup_For_Carbondata.md is for cluster.  Can you add link for each other?


---

[qiuchenjian-2]

Github user BeyondYourself commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3015#discussion_r244162754
 
    --- Diff: docs/quick-start-guide.md ---
    @@ -461,3 +464,82 @@ select * from carbon_table;
     
     **Note :** Create Tables and data loads should be done before executing queries as we can not create carbon table from this interface.
     
    +## Installing and Configuring CarbonData on Hive
    +### Build (In 1.2.0, hive integration only support spark2.1 and hadoop2.7.2)
    --- End diff --
   
    Yeah, I can not agree with you any more ,it is convenient for us to maintenance document


---

[qiuchenjian-2]

Github user BeyondYourself commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3015#discussion_r244179772
 
    --- Diff: README.md ---
    @@ -67,6 +67,10 @@ CarbonData is built using Apache Maven, to [build CarbonData](https://github.com
     * [Carbon as Spark's Datasource](https://github.com/apache/carbondata/blob/master/docs/carbon-as-spark-datasource-guide.md)
     * [FAQs](https://github.com/apache/carbondata/blob/master/docs/faq.md)
     
    +##  Integrations
    +* [Hive](https://github.com/apache/carbondata/blob/master/docs/hive-guide.md)
    +* [Presto](https://github.com/apache/carbondata/blob/master/integration/presto/Presto_Cluster_Setup_For_Carbondata.md)
    --- End diff --
   
    OK,I have unify it i,and move the doc to the docs folder and rename the doc to the presto-guide


---

[qiuchenjian-2]

Github user BeyondYourself commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3015#discussion_r244182879
 
    --- Diff: docs/presto-guide.md ---
    @@ -1,21 +1,148 @@
    -<!--
    -    Licensed to the Apache Software Foundation (ASF) under one or more
    -    contributor license agreements.  See the NOTICE file distributed with
    -    this work for additional information regarding copyright ownership.
    -    The ASF licenses this file to you under the Apache License, Version 2.0
    -    (the "License"); you may not use this file except in compliance with
    -    the License.  You may obtain a copy of the License at
     
    --- End diff --
   
    I move the integration/presto/README.md and the /presto/Presto_Cluster_Setup_For_Carbondata.md  documents to the docs/ , merge them  and rename it to the presto-guide


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3015#discussion_r244259184
 
    --- Diff: docs/presto-guide.md ---
    @@ -1,21 +1,148 @@
    -<!--
    -    Licensed to the Apache Software Foundation (ASF) under one or more
    --- End diff --
   
    please keep License, it shouldn't be deleted.


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3015#discussion_r244259267
 
    --- Diff: docs/presto-guide.md ---
    @@ -1,21 +1,148 @@
    -<!--
    -    Licensed to the Apache Software Foundation (ASF) under one or more
    -    contributor license agreements.  See the NOTICE file distributed with
    -    this work for additional information regarding copyright ownership.
    -    The ASF licenses this file to you under the Apache License, Version 2.0
    -    (the "License"); you may not use this file except in compliance with
    -    the License.  You may obtain a copy of the License at
     
    -      http://www.apache.org/licenses/LICENSE-2.0
    +# Presto guide
    +This tutorial provides a quick introduction to using current integration/presto module.
     
    -    Unless required by applicable law or agreed to in writing, software
    -    distributed under the License is distributed on an "AS IS" BASIS,
    -    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    -    See the License for the specific language governing permissions and
    -    limitations under the License.
    --->
     
    -Please follow the below steps to query carbondata in presto
    +[Presto Multinode Cluster setup For Carbondata](#presto-multinode-cluster-setup-for-carbondata)
    --- End diff --
   
    Please optimize the upper/lower case


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3015#discussion_r244259273
 
    --- Diff: docs/presto-guide.md ---
    @@ -1,21 +1,148 @@
    -<!--
    -    Licensed to the Apache Software Foundation (ASF) under one or more
    -    contributor license agreements.  See the NOTICE file distributed with
    -    this work for additional information regarding copyright ownership.
    -    The ASF licenses this file to you under the Apache License, Version 2.0
    -    (the "License"); you may not use this file except in compliance with
    -    the License.  You may obtain a copy of the License at
     
    -      http://www.apache.org/licenses/LICENSE-2.0
    +# Presto guide
    +This tutorial provides a quick introduction to using current integration/presto module.
     
    -    Unless required by applicable law or agreed to in writing, software
    -    distributed under the License is distributed on an "AS IS" BASIS,
    -    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    -    See the License for the specific language governing permissions and
    -    limitations under the License.
    --->
     
    -Please follow the below steps to query carbondata in presto
    +[Presto Multinode Cluster setup For Carbondata](#presto-multinode-cluster-setup-for-carbondata)
    +
    +[Presto Single node setup For Carbondata](#presto-single-node-setup-for-carbondata)
    --- End diff --
   
    Please optimize the upper/lower case


---