[GitHub] carbondata pull request #3018: [HOTFIX] rename field "thread_pool_size" to m...

[qiuchenjian-2]

GitHub user lamber-ken opened a pull request:

    https://github.com/apache/carbondata/pull/3018

    [HOTFIX] rename field "thread_pool_size" to match camel case

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [x] Any interfaces changed? NO
     
     - [x] Any backward compatibility impacted? NO
     
     - [x] Document update required? NO
   
     - [x] Testing done YES
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. OK
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/BigDataArtisans/carbondata hotfix-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/3018.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3018
   
----
commit 842a5006763ef5f5375bdd01a6fda02e6420ebf4
Author: lamber-ken <2217232293@...>
Date:   2018-12-23T15:52:15Z

    [HOTFIX] rename field "thread_pool_size" to match camel case

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3018
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1911/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3018
 
    Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10165/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3018
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2122/



---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/3018
 
    Can you please explain , why need to rename?


---

[qiuchenjian-2]

Github user lamber-ken commented on the issue:

    https://github.com/apache/carbondata/pull/3018
 
    > Can you please explain , why need to rename?
   
    thanks for review, `thread_pool_size` doesn't match java code style.
    for example, field names may be `carbonLRUCache`, `dictionaryColumnUniqueIdentifier` etc
   



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3018
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1956/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3018
 
    Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10209/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3018
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2231/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/3018
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/3018


---