[GitHub] carbondata pull request #3020: [CARBONDATA-3195]Added validation for Inverte...

classic Classic list List threaded Threaded
21 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #3020: [CARBONDATA-3195]Added validation for Inverte...

qiuchenjian-2
GitHub user shardul-cr7 opened a pull request:

    https://github.com/apache/carbondata/pull/3020

    [CARBONDATA-3195]Added validation for Inverted INdex columns and added a test case in case of varchar

   
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shardul-cr7/carbondata 21dec

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/3020.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3020
   
----
commit 6374825a94b055a1a9d196ae151a01e2c9d3805e
Author: shardul-cr7 <shardulsingh22@...>
Date:   2018-12-24T07:21:16Z

    Added validation for Inverted INdex columns and added a test case in case of varchar

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3020: [CARBONDATA-3195]Added validation for Inverted INdex...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3020
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1922/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3020: [CARBONDATA-3195]Added validation for Inverted Index...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3020
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2133/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3020: [CARBONDATA-3195]Added validation for Inverted Index...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3020
 
    Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10175/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3020: [CARBONDATA-3195]Added validation for Inverted Index...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3020
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1926/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3020: [CARBONDATA-3195]Added validation for Inverted Index...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3020
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2136/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3020: [CARBONDATA-3195]Added validation for Inverted Index...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3020
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1927/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3020: [CARBONDATA-3195]Added validation for Inverted Index...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3020
 
    Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10180/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3020: [CARBONDATA-3195]Added validation for Inverted Index...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3020
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2137/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3020: [CARBONDATA-3195]Added validation for Inverted Index...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user qiuchenjian commented on the issue:

    https://github.com/apache/carbondata/pull/3020
 
    I think you need describe this validation in the ddl-of-carbondata.md of Inverted Index Configuration part


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3020: [CARBONDATA-3195]Added validation for Inverted Index...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3020
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1954/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3020: [CARBONDATA-3195]Added validation for Inverted Index...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user shardul-cr7 commented on the issue:

    https://github.com/apache/carbondata/pull/3020
 
   
   
   
    > I think you need describe this validation in the ddl-of-carbondata.md of Inverted Index Configuration part
   
    Done!


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3020: [CARBONDATA-3195]Added validation for Inverted Index...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3020
 
    Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10207/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3020: [CARBONDATA-3195]Added validation for Inverted Index...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3020
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2229/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #3020: [CARBONDATA-3195]Added validation for Inverte...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ajantha-bhat commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3020#discussion_r244147232
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/longstring/VarcharDataTypesBasicTestCase.scala ---
    @@ -191,6 +191,19 @@ class VarcharDataTypesBasicTestCase extends QueryTest with BeforeAndAfterEach wi
         assert(exceptionCaught.getMessage.contains("both in no_inverted_index and long_string_columns"))
       }
     
    +  test("inverted index columns cannot be present in long_string_cols as they do not support sort_cols") {
    +    val exceptionCaught = intercept[MalformedCarbonCommandException] {
    +      sql(
    +        s"""
    +           | CREATE TABLE if not exists $longStringTable(
    +           | id INT, name STRING, description STRING, address STRING, note STRING
    +           | ) STORED BY 'carbondata'
    +           | TBLPROPERTIES('inverted_index'='note', 'long_string_columns'='note,description')
    +           |""".stripMargin)
    +    }
    +    assert(exceptionCaught.getMessage.contains("should be present in SORT_COLUMN(s)"))
    --- End diff --
   
    Add a complete message during validation


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3020: [CARBONDATA-3195]Added validation for Inverted Index...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3020
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2258/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3020: [CARBONDATA-3195]Added validation for Inverted Index...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3020
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2052/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3020: [CARBONDATA-3195]Added validation for Inverted Index...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3020
 
    Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10304/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3020: [CARBONDATA-3195]Added validation for Inverted Index...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ajantha-bhat commented on the issue:

    https://github.com/apache/carbondata/pull/3020
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3020: [CARBONDATA-3195]Added validation for Inverted Index...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/3020
 
    LGTM


---
12