[GitHub] carbondata pull request #3031: [CARBONDATA-3212] Fixed NegativeArraySizeExce...

classic Classic list List threaded Threaded
14 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #3031: [CARBONDATA-3212] Fixed NegativeArraySizeExce...

qiuchenjian-2
GitHub user shivamasn opened a pull request:

    https://github.com/apache/carbondata/pull/3031

    [CARBONDATA-3212] Fixed NegativeArraySizeException while querying in specific scenario

    ### What was the issue?
    In Local Dictionary, page size was not getting updated. So during fallback, new page was being created with less records giving NegativeArraySizeException while querying data.
   
    ### What has been changed?
    Updated the page size in Local Dictionary.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shivamasn/carbondata negative_index_exception

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/3031.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3031
   
----
commit a8f945d178c00ad11872f33326d7860ee47dfb52
Author: shivamasn <shivamasn17@...>
Date:   2018-12-28T05:32:51Z

    NegativeArraySizeException Fixed

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #3031: [CARBONDATA-3212] Fixed NegativeArraySizeExce...

qiuchenjian-2
Github user qiuchenjian commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3031#discussion_r244269580
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/LocalDictColumnPage.java ---
    @@ -140,6 +140,7 @@ public boolean isLocalDictGeneratedPage() {
         } else {
           actualDataColumnPage.putBytes(rowId, bytes);
         }
    +    pageSize = rowId + 1;
    --- End diff --
   
    ```suggestion
        if (pageSize <= rowId) {
            pageSize = rowId + 1;
        }
    ```
   
    LocalDictColumnPage construct method has init pageSize in line 80, I think it's better to compare rowId and pageSize


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3031: [CARBONDATA-3212] Fixed NegativeArraySizeException w...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3031
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2059/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3031: [CARBONDATA-3212] Fixed NegativeArraySizeException w...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3031
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2263/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3031: [CARBONDATA-3212] Fixed NegativeArraySizeException w...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3031
 
    Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10311/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #3031: [CARBONDATA-3212] Fixed NegativeArraySizeExce...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3031#discussion_r244639643
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/LocalDictColumnPage.java ---
    @@ -140,6 +140,7 @@ public boolean isLocalDictGeneratedPage() {
         } else {
           actualDataColumnPage.putBytes(rowId, bytes);
         }
    +    pageSize = rowId + 1;
    --- End diff --
   
    So we need to update the pageSize each time we put a row to the page? It is so waste of calculation.
    Please reconsider the implementation.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3031: [CARBONDATA-3212] Fixed NegativeArraySizeException w...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3031
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2117/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3031: [CARBONDATA-3212] Fixed NegativeArraySizeException w...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3031
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2322/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3031: [CARBONDATA-3212] Fixed NegativeArraySizeException w...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3031
 
    Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10371/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #3031: [CARBONDATA-3212] Fixed NegativeArraySizeExce...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user shivamasn commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3031#discussion_r244755533
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/LocalDictColumnPage.java ---
    @@ -140,6 +140,7 @@ public boolean isLocalDictGeneratedPage() {
         } else {
           actualDataColumnPage.putBytes(rowId, bytes);
         }
    +    pageSize = rowId + 1;
    --- End diff --
   
    @xuchuanyin @qiuchenjian Is it ok now?



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #3031: [CARBONDATA-3212] Fixed NegativeArraySizeExce...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3031#discussion_r244914880
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/LocalDictColumnPage.java ---
    @@ -140,6 +140,7 @@ public boolean isLocalDictGeneratedPage() {
         } else {
           actualDataColumnPage.putBytes(rowId, bytes);
         }
    +    pageSize = rowId + 1;
    --- End diff --
   
    I think it's okay now ....for complex type children like array<string> it can have more than 32k elements so page size also need to be changes


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3031: [CARBONDATA-3212] Fixed NegativeArraySizeException w...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/3031
 
    @shivamasn Please update the PR details....
    In Local Dictionary, page size was not getting updated for complex children columns. So during fallback, new page was being created with less records giving NegativeArraySizeException while querying data.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3031: [CARBONDATA-3212] Fixed NegativeArraySizeException w...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/3031
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #3031: [CARBONDATA-3212] Fixed NegativeArraySizeExce...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/3031


---