Apache CarbonData Dev Mailing List archive › Apache CarbonData JIRA issues

[GitHub] carbondata pull request #3033: [CARBONDATA-3215] Optimize the documentation

Classic

List

Threaded

22 messages Options

qiuchenjian-2

[GitHub] carbondata pull request #3033: [CARBONDATA-3215] Optimize the documentation

GitHub user xubo245 opened a pull request:

https://github.com/apache/carbondata/pull/3033

[CARBONDATA-3215] Optimize the documentation

When user use the Global dictionary, local dictionaryï¼non-dictionary in the code, users maybe have some confusion. The same for mvdataMap and IndexDataMap. I describe and list it in this PR.
1. describe Global dictionary, local dictionaryï¼non-dictionary together in doc
2. list mvdataMap and IndexDataMap

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

- [ ] Any interfaces changed?
No
- [ ] Any backward compatibility impacted?
No
- [ ] Document update required?
yes, only update the doc
- [ ] Testing done
No need

- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
No

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xubo245/carbondata CARBONDATA-3215_OptimizeDoc

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/3033.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3033

----
commit 1eae260dcbddadb592357e0f71309d27960de6c0
Author: xubo245 <xubo29@...>
Date: 2018-12-28T12:23:13Z

[CARBONDATA-3215] Optimize the documentation
1. describe Global dictionary local dictionaryï¼non-dictionary together in doc
2. list mvdataMap and IndexDataMap

----

---

qiuchenjian-2

[GitHub] carbondata issue #3033: [CARBONDATA-3215] Optimize the documentation

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/3033

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2068/

---

qiuchenjian-2

[GitHub] carbondata issue #3033: [CARBONDATA-3215] Optimize the documentation

In reply to this post by qiuchenjian-2

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/3033

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2273/

---

qiuchenjian-2

[GitHub] carbondata issue #3033: [CARBONDATA-3215] Optimize the documentation

In reply to this post by qiuchenjian-2

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/3033

Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10322/

---

qiuchenjian-2

[GitHub] carbondata pull request #3033: [CARBONDATA-3215] Optimize the documentation

In reply to this post by qiuchenjian-2

Github user qiuchenjian commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/3033#discussion_r244441456

--- Diff: docs/datamap-developer-guide.md ---
@@ -3,15 +3,15 @@
### Introduction
DataMap is a data structure that can be used to accelerate certain query of the table. Different DataMap can be implemented by developers.
Currently, there are two 2 types of DataMap supported:
--- End diff --

```suggestion
Currently, there are two types of DataMap supported:
```

---

qiuchenjian-2

[GitHub] carbondata pull request #3033: [CARBONDATA-3215] Optimize the documentation

In reply to this post by qiuchenjian-2

Github user xubo245 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/3033#discussion_r244475523

--- Diff: docs/datamap-developer-guide.md ---
@@ -3,15 +3,15 @@
### Introduction
DataMap is a data structure that can be used to accelerate certain query of the table. Different DataMap can be implemented by developers.
Currently, there are two 2 types of DataMap supported:
--- End diff --

done, thanks

---

qiuchenjian-2