[GitHub] carbondata pull request #3034: [CARBONDATA-3126]Correct some spell error in ...

classic Classic list List threaded Threaded
19 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #3034: [CARBONDATA-3126]Correct some spell error in ...

qiuchenjian-2
GitHub user tisonkong opened a pull request:

    https://github.com/apache/carbondata/pull/3034

    [CARBONDATA-3126]Correct some spell error in CarbonData

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     some spell error,modified some local variable quantity.
     - [ ] Any backward compatibility impacted?
     No
     - [ ] Document update required?
    No
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tisonkong/carbondata master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/3034.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3034
   
----
commit fb986601f43e79c4ba7c6ad0b95e701b4e20b647
Author: tisonkong <360548494@...>
Date:   2018-12-29T02:02:27Z

    [CARBONDATA-3126]Correct some spell error in CarbonData

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #3034: [CARBONDATA-3126]Correct some spell error in ...

qiuchenjian-2
Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3034#discussion_r244442392
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ---
    @@ -84,7 +84,7 @@
       private static final CarbonProperties CARBONPROPERTIESINSTANCE = new CarbonProperties();
     
       /**
    -   * porpeties .
    +   * porpeties
    --- End diff --
   
    porpeties should be Properties, can you describe it in detail?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3034: [CARBONDATA-3126]Correct some spell error in CarbonD...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3034
 
    Can one of the admins verify this patch?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3034: [CARBONDATA-3126]Correct some spell error in CarbonD...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/3034
 
    add to whitelist


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3034: [CARBONDATA-3126]Correct some spell error in CarbonD...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/3034
 
    add to whitelist


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3034: [CARBONDATA-3126]Correct some spell error in CarbonD...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/3034
 
    LGTM.
    One small issue, for pr title, please add one "blank" after [CARBONDATA-3126]



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3034: [CARBONDATA-3126]Correct some spell error in CarbonD...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user tisonkong commented on the issue:

    https://github.com/apache/carbondata/pull/3034
 
    > LGTM.
    > One small issue, for pr title, please add one "blank" after [CARBONDATA-3126]
   
    No problem. I see some has blank and some not, i will add blank after brackets next time .


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3034: [CARBONDATA-3126]Correct some spell error in CarbonD...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3034
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2077/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3034: [CARBONDATA-3126]Correct some spell error in CarbonD...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3034
 
    Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10331/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3034: [CARBONDATA-3126]Correct some spell error in CarbonD...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3034
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2282/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #3034: [CARBONDATA-3126]Correct some spell error in ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user tisonkong commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3034#discussion_r244465150
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ---
    @@ -84,7 +84,7 @@
       private static final CarbonProperties CARBONPROPERTIESINSTANCE = new CarbonProperties();
     
       /**
    -   * porpeties .
    +   * porpeties
    --- End diff --
   
    Right, this spell error has corrected


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3034: [CARBONDATA-3126]Correct some spell error in CarbonD...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/3034
 
    Please fix the CI error.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3034: [CARBONDATA-3126]Correct some spell error in CarbonD...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user tisonkong commented on the issue:

    https://github.com/apache/carbondata/pull/3034
 
    > Please fix the CI error. @tisonkong
   
    I found the error reason is "line is longer than 100 characters" in DictionaryBasedVectorResultCollector. I have take a newline to fix this problem.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3034: [CARBONDATA-3126]Correct some spell error in CarbonD...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user tisonkong commented on the issue:

    https://github.com/apache/carbondata/pull/3034
 
    > Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2282/
   
    I found the error reason is "line is longer than 100 characters" in DictionaryBasedVectorResultCollector. I have take a newline to fix this problem. Please try agin, thank u.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3034: [CARBONDATA-3126]Correct some spell error in CarbonD...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3034
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2081/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3034: [CARBONDATA-3126] Correct some spell error in Carbon...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3034
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2286/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3034: [CARBONDATA-3126] Correct some spell error in Carbon...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3034
 
    Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10335/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3034: [CARBONDATA-3126] Correct some spell error in Carbon...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/3034
 
    LGTM,Thank you for working on it. @tisonkong


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #3034: [CARBONDATA-3126] Correct some spell error in...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/3034


---