[GitHub] carbondata pull request #3036: [CARBONDATA-3208]Remove unused parameters and...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3036
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2078/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3036
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2283/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3036
 
    Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10332/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/3036
 
    Please optimize the title， this PR is not only for unused import, also optimize the spell error, so please add it too. @runzhliu


---

[qiuchenjian-2]

Github user runzhliu commented on the issue:

    https://github.com/apache/carbondata/pull/3036
 
    @xubo245 Done.


---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/3036
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3036
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2087/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3036
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2292/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3036
 
    Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10341/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3036
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2089/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3036
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2294/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3036
 
    Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10343/



---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/3036
 
    LGTM, thanks for the good contributions.


---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3036#discussion_r244535093
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/block/SegmentProperties.java ---
    @@ -287,31 +287,31 @@ private void fillDimensionAndMeasureDetails(List<ColumnSchema> columnsInTable,
               // if it is a columnar dimension participated in mdkey then added
               // key ordinal and dimension ordinal
               carbonDimension =
    -              new CarbonDimension(columnSchema, dimensonOrdinal++, keyOrdinal++, -1);
    +              new CarbonDimension(columnSchema, dimensionOrdinal++, keyOrdinal++, -1);
             }
             // as complex type will be stored at last so once complex type started all the dimension
             // will be added to complex type
             else if (isComplexDimensionStarted || columnSchema.getDataType().isComplexType()) {
               cardinalityIndexForComplexDimensionColumn.add(tableOrdinal);
               carbonDimension =
    -              new CarbonDimension(columnSchema, dimensonOrdinal++, -1, ++complexTypeOrdinal);
    +              new CarbonDimension(columnSchema, dimensionOrdinal++, -1, ++complexTypeOrdinal);
               carbonDimension.initializeChildDimensionsList(columnSchema.getNumberOfChild());
               complexDimensions.add(carbonDimension);
               isComplexDimensionStarted = true;
    -          int previouseOrdinal = dimensonOrdinal;
    -          dimensonOrdinal =
    -              readAllComplexTypeChildren(dimensonOrdinal, columnSchema.getNumberOfChild(),
    +          int previouseOrdinal = dimensionOrdinal;
    --- End diff --
   
    um, part of the variable name 'previouse' is also typo, which should be 'previous'...
    Please correct this also and others LGTM.


---

[qiuchenjian-2]

Github user runzhliu commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3036#discussion_r244537813
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/block/SegmentProperties.java ---
    @@ -287,31 +287,31 @@ private void fillDimensionAndMeasureDetails(List<ColumnSchema> columnsInTable,
               // if it is a columnar dimension participated in mdkey then added
               // key ordinal and dimension ordinal
               carbonDimension =
    -              new CarbonDimension(columnSchema, dimensonOrdinal++, keyOrdinal++, -1);
    +              new CarbonDimension(columnSchema, dimensionOrdinal++, keyOrdinal++, -1);
             }
             // as complex type will be stored at last so once complex type started all the dimension
             // will be added to complex type
             else if (isComplexDimensionStarted || columnSchema.getDataType().isComplexType()) {
               cardinalityIndexForComplexDimensionColumn.add(tableOrdinal);
               carbonDimension =
    -              new CarbonDimension(columnSchema, dimensonOrdinal++, -1, ++complexTypeOrdinal);
    +              new CarbonDimension(columnSchema, dimensionOrdinal++, -1, ++complexTypeOrdinal);
               carbonDimension.initializeChildDimensionsList(columnSchema.getNumberOfChild());
               complexDimensions.add(carbonDimension);
               isComplexDimensionStarted = true;
    -          int previouseOrdinal = dimensonOrdinal;
    -          dimensonOrdinal =
    -              readAllComplexTypeChildren(dimensonOrdinal, columnSchema.getNumberOfChild(),
    +          int previouseOrdinal = dimensionOrdinal;
    --- End diff --
   
    Thanks to point it out! I have fixed it :)


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3036
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2092/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3036
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2297/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3036
 
    Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10346/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3036
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2093/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3036
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2298/



---