[GitHub] carbondata pull request #3060: [HOTFIX] Exclude filter doesn't work in prest...

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #3060: [HOTFIX] Exclude filter doesn't work in prest...

qiuchenjian-2
GitHub user ajantha-bhat opened a pull request:

    https://github.com/apache/carbondata/pull/3060

    [HOTFIX] Exclude filter doesn't work in presto carbon in cluster

    **problem:** exclude filter fails in cluster for presto carbon with exception.
    ```
    java.lang.NoClassDefFoundError: org/roaringbitmap/RoaringBitmap
            at org.apache.carbondata.core.scan.filter.FilterUtil.prepareExcludeFilterMembers(FilterUtil.java:826)
            at org.apache.carbondata.core.scan.filter.FilterUtil.getDimColumnFilterInfoAfterApplyingCBO(FilterUtil.java:776)
            at org.apache.carbondata.core.scan.filter.FilterUtil.getFilterListForAllValues(FilterUtil.java:884)
   
    ```        
    **cause:**  RoaringBitmap jar is not added in the dependency, hence it is not present in the presto snapshot folder.
    **solution** : include RoaringBitmap in dependency.
   
   
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed? NA
     
     - [ ] Any backward compatibility impacted? NA
     
     - [ ] Document update required? NA
   
     - [ ] Testing done. please find the report
    **Before:**
    ```
    presto:default> select name from nbig where name < 'aj' limit 5;
    Query 20190109_131447_00004_qhrfk failed: org/roaringbitmap/RoaringBitmap
   
    ```
    **After:**
   
    ```
    presto:default> select name from nbig where name < 'aj' limit 5;
      name  
    --------
     208    
     150209
     150210
     150211
     150212
    (5 rows)
    ```
   
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. NA
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ajantha-bhat/carbondata issue_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/3060.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3060
   
----
commit b3041adb284a0aa30a64e55908e6b99eeee04c29
Author: ajantha-bhat <ajanthabhat@...>
Date:   2019-01-09T13:26:10Z

    Fix Roaring bit map exception in presto filter query

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3060: [HOTFIX] Exclude filter doesn't work in presto carbo...

qiuchenjian-2
Github user ajantha-bhat commented on the issue:

    https://github.com/apache/carbondata/pull/3060
 
    @ravipesala : please check.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3060: [HOTFIX] Exclude filter doesn't work in presto carbo...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3060
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2243/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3060: [HOTFIX] Exclude filter doesn't work in presto carbo...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3060
 
    Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10500/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3060: [HOTFIX] Exclude filter doesn't work in presto carbo...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3060
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2462/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3060: [HOTFIX] Exclude filter doesn't work in presto carbo...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user qiuchenjian commented on the issue:

    https://github.com/apache/carbondata/pull/3060
 
    Is there test case to test this scene (use 'exclude filter' in presto carbon ), if not, better to add test case, so that other's changes will not affect this feature.



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3060: [HOTFIX] Exclude filter doesn't work in presto carbo...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ajantha-bhat commented on the issue:

    https://github.com/apache/carbondata/pull/3060
 
    @qiuchenjian : Test cases are there, But problem comes only in the cluster. Not in local environment due to jar dependency.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #3060: [HOTFIX] Exclude filter doesn't work in presto carbo...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/3060
 
    LGTM


---