[GitHub] carbondata pull request #3063: [CARBONDATA-3242] Move Range_Column into the ...

[qiuchenjian-2]

GitHub user QiangCai opened a pull request:

    https://github.com/apache/carbondata/pull/3063

    [CARBONDATA-3242] Move Range_Column into the table level properties

    Move Range_Column into the table level properties
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/QiangCai/carbondata range_column_table_level

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/3063.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3063
   
----
commit ac1a93e0088f3988831393458d6e771f4105027a
Author: QiangCai <qiangcai@...>
Date:   2019-01-10T13:03:14Z

    move Range_Column to table level

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3063
 
    Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10510/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3063
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2471/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3063
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2252/



---

[qiuchenjian-2]

Github user qiuchenjian commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3063#discussion_r246973311
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java ---
    @@ -947,6 +947,16 @@ public int getNumberOfNoDictSortColumns() {
         return numberOfNoDictSortColumns;
       }
     
    +  public CarbonColumn getRangeColumn() {
    +    String rangeColumn =
    +        tableInfo.getFactTable().getTableProperties().get(CarbonCommonConstants.RANGE_COLUMN);
    +    if (rangeColumn == null) {
    --- End diff --
   
    Does this branch need to judge that rangeColumn is ""


---

[qiuchenjian-2]

Github user qiuchenjian commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3063#discussion_r246973727
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ---
    @@ -1364,6 +1365,29 @@ public int getHeapMemoryPoolingThresholdBytes() {
         return thresholdSize;
       }
     
    +  public int getRangeColumnScaleFactor() {
    +    boolean isValid = true;
    +    int scaleFactor = 1;
    +    try {
    +      scaleFactor = Integer.parseInt(CarbonProperties.getInstance().getProperty(
    +          CarbonCommonConstants.CARBON_RANGE_COLUMN_SCALE_FACTOR,
    +          CarbonCommonConstants.CARBON_RANGE_COLUMN_SCALE_FACTOR_DEFAULT));
    +      if (scaleFactor < 1 || scaleFactor > 300) {
    +        isValid = false;
    +      }
    +    } catch (NumberFormatException ex) {
    +      isValid = false;
    --- End diff --
   
    ```suggestion
          LOGGER.warn("Range column scala factor isn't number format");
          isValid = false;
    ```


---

[qiuchenjian-2]

Github user qiuchenjian commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3063#discussion_r246973842
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ---
    @@ -1364,6 +1365,29 @@ public int getHeapMemoryPoolingThresholdBytes() {
         return thresholdSize;
       }
     
    +  public int getRangeColumnScaleFactor() {
    +    boolean isValid = true;
    +    int scaleFactor = 1;
    +    try {
    +      scaleFactor = Integer.parseInt(CarbonProperties.getInstance().getProperty(
    +          CarbonCommonConstants.CARBON_RANGE_COLUMN_SCALE_FACTOR,
    +          CarbonCommonConstants.CARBON_RANGE_COLUMN_SCALE_FACTOR_DEFAULT));
    +      if (scaleFactor < 1 || scaleFactor > 300) {
    +        isValid = false;
    +      }
    +    } catch (NumberFormatException ex) {
    +      isValid = false;
    --- End diff --
   
    better to add a log to record exception or scaleFactor < 1 || scaleFactor > 300


---

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3063#discussion_r246978328
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java ---
    @@ -947,6 +947,16 @@ public int getNumberOfNoDictSortColumns() {
         return numberOfNoDictSortColumns;
       }
     
    +  public CarbonColumn getRangeColumn() {
    +    String rangeColumn =
    +        tableInfo.getFactTable().getTableProperties().get(CarbonCommonConstants.RANGE_COLUMN);
    +    if (rangeColumn == null) {
    --- End diff --
   
    yes, create table command and set property will do it.
    "" is invalid.


---

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3063#discussion_r246979073
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ---
    @@ -1364,6 +1365,29 @@ public int getHeapMemoryPoolingThresholdBytes() {
         return thresholdSize;
       }
     
    +  public int getRangeColumnScaleFactor() {
    +    boolean isValid = true;
    +    int scaleFactor = 1;
    +    try {
    +      scaleFactor = Integer.parseInt(CarbonProperties.getInstance().getProperty(
    +          CarbonCommonConstants.CARBON_RANGE_COLUMN_SCALE_FACTOR,
    +          CarbonCommonConstants.CARBON_RANGE_COLUMN_SCALE_FACTOR_DEFAULT));
    +      if (scaleFactor < 1 || scaleFactor > 300) {
    +        isValid = false;
    +      }
    +    } catch (NumberFormatException ex) {
    +      isValid = false;
    --- End diff --
   
    accept


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3063
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2478/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3063
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2259/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3063
 
    Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10517/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3063
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2265/



---