[GitHub] carbondata pull request #3064: [WIP] Updated DOC for No-Sort Compaction and ...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3064
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2267/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3064
 
    Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10525/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3064
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2486/



---

[qiuchenjian-2]

Github user shardul-cr7 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3064#discussion_r247096965
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala ---
    @@ -1201,6 +1202,17 @@ abstract class CarbonDDLSqlParser extends AbstractCarbonSparkSQLParser {
             }
           }
     
    +    // Validate SORT_SCOPE
    +    if(options.exists(_._1.equalsIgnoreCase("SORT_SCOPE"))) {
    +      val optionValue: String = options.get("sort_scope").get.head._2
    +      if (!CarbonUtil.isValidSortOption(optionValue)) {
    +        throw new InvalidConfigurationException(
    +          s"Passing invalid SORT_SCOPE '$optionValue', valid SORT_SCOPE are 'NO_SORT'," +
    +          s" 'BATCH_SORT', 'LOCAL_SORT' and 'GLOBAL_SORT' ")
    +      }
    +
    +    }
    +
    --- End diff --
   
   
   
    Remove empty lines and properly format the code.



---

[qiuchenjian-2]

Github user NamanRastogi commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3064#discussion_r247097474
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala ---
    @@ -1201,6 +1202,17 @@ abstract class CarbonDDLSqlParser extends AbstractCarbonSparkSQLParser {
             }
           }
     
    +    // Validate SORT_SCOPE
    +    if(options.exists(_._1.equalsIgnoreCase("SORT_SCOPE"))) {
    +      val optionValue: String = options.get("sort_scope").get.head._2
    +      if (!CarbonUtil.isValidSortOption(optionValue)) {
    +        throw new InvalidConfigurationException(
    +          s"Passing invalid SORT_SCOPE '$optionValue', valid SORT_SCOPE are 'NO_SORT'," +
    +          s" 'BATCH_SORT', 'LOCAL_SORT' and 'GLOBAL_SORT' ")
    +      }
    +
    +    }
    +
    --- End diff --
   
    Done.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3064
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2274/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3064
 
    Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10533/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3064
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2494/



---