[GitHub] carbondata pull request #3065: Optimize presto-guide

[qiuchenjian-2]

GitHub user chenliang613 opened a pull request:

    https://github.com/apache/carbondata/pull/3065

    Optimize presto-guide

    Some users made mistake: copy the assemble jar. Add more description to clarify, need to copy many jars from integration/presto/target/carbondata-presto-x.x.x-SNAPSHOT
   
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chenliang613/carbondata patch-9

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/3065.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3065
   
----
commit b9b629f5b114ced1034761a1f39ca9c8adda1e8f
Author: Liang Chen <chenliang6136@...>
Date:   2019-01-10T15:28:38Z

    Optimize presto-guide
   
    Some users made mistake: copy the assemble jar. Add more description to clarify, need to copy many jars from integration/presto/target/carbondata-presto-x.x.x-SNAPSHOT

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3065
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2257/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3065
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2476/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3065
 
    Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10515/



---

[qiuchenjian-2]

Github user qiuchenjian commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3065#discussion_r246972785
 
    --- Diff: docs/presto-guide.md ---
    @@ -220,7 +220,8 @@ Now you can use the Presto CLI on the coordinator to query data sources in the c
       Secondly: Create a folder named 'carbondata' under $PRESTO_HOME$/plugin and
       copy all jars from carbondata/integration/presto/target/carbondata-presto-x.x.x-SNAPSHOT
             to $PRESTO_HOME$/plugin/carbondata
    -
    +  **NOTE:**  Not copy one assemble jar, need to copy many jars from integration/presto/target/carbondata-presto-x.x.x-SNAPSHOT
    --- End diff --
   
    ```suggestion
      **NOTE:**  Don't just copy assemble jar, make sure to copy all jars from integration/presto/target/carbondata-presto-x.x.x-SNAPSHOT
    ```


---

[qiuchenjian-2]

Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/3065
 
    @chenliang613 I think it's better give a 'NOTE' that it's also support presto 0.210+, for example 0.214 version.


---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/3065
 
    Please optimize the title.


---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/3065
 
    @zzcclp I think we should test before change to 0.210+


---

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3065#discussion_r246996198
 
    --- Diff: docs/presto-guide.md ---
    @@ -220,7 +220,8 @@ Now you can use the Presto CLI on the coordinator to query data sources in the c
       Secondly: Create a folder named 'carbondata' under $PRESTO_HOME$/plugin and
       copy all jars from carbondata/integration/presto/target/carbondata-presto-x.x.x-SNAPSHOT
             to $PRESTO_HOME$/plugin/carbondata
    -
    +  **NOTE:**  Not copy one assemble jar, need to copy many jars from integration/presto/target/carbondata-presto-x.x.x-SNAPSHOT
    --- End diff --
   
    How about : Not copy the assemble jar, make sure to copy all jars ...


---

[qiuchenjian-2]

Github user qiuchenjian commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3065#discussion_r246997808
 
    --- Diff: docs/presto-guide.md ---
    @@ -220,7 +220,8 @@ Now you can use the Presto CLI on the coordinator to query data sources in the c
       Secondly: Create a folder named 'carbondata' under $PRESTO_HOME$/plugin and
       copy all jars from carbondata/integration/presto/target/carbondata-presto-x.x.x-SNAPSHOT
             to $PRESTO_HOME$/plugin/carbondata
    -
    +  **NOTE:**  Not copy one assemble jar, need to copy many jars from integration/presto/target/carbondata-presto-x.x.x-SNAPSHOT
    --- End diff --
   
    @chenliang613  "Not copy" is oral， suggest  â€œNo need to copy assemble jar” or “”assemble jar is not required“”


---

[qiuchenjian-2]

Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/3065
 
    @xubo245 our team had tested with presto 0.214 and @jackylk tested too.


---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/3065
 
    I mean we need test 0.210,0.211,0.212,0.213,.....  when it change to 0.210+


---

[qiuchenjian-2]

Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/3065
 
    @xubo245 yup, you are right, but we can't test them one by one, we can note that it also supports presto 0.214, is it ok?


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/3065
 
    @zzcclp Can you verify the presto with current master. There are changes related to Hive metastore is done now. So now carbon behaves as a one of the hive supported format in presto. Please check and let us know your feedback.


---

[qiuchenjian-2]

Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/3065
 
    @ravipesala NP, another team of our company will test this and the feature of supporting reading stream segment. Will let you know the feedback.


---