[GitHub] carbondata pull request #919: [CARBONDATA-1056] Added check for starting dic...

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #919: [CARBONDATA-1056] Added check for starting dic...

qiuchenjian-2
GitHub user kunal642 opened a pull request:

    https://github.com/apache/carbondata/pull/919

    [CARBONDATA-1056] Added check for starting dictionary server

    Analysis: If all the dictionary columns are marked as dictionary exclude then the dictionary generator is not created for that table but there was no check in the data loading flow for the same. Thus the query fails with "cannot write dictionary" exception.
   
    Solution: Added check in the loading flow for Dictionary and DirectDictionary encoding

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kunal642/incubator-carbondata CARBONDATA-1056

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/919.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #919
   
----
commit 052bec0436eea7262fe8e74b409ad2d423baad45
Author: kunal642 <[hidden email]>
Date:   2017-05-17T07:37:12Z

    added check for starting dictionary server

commit 043b6add6f378db15b7e9de0671b0bf94d5c00ba
Author: kunal642 <[hidden email]>
Date:   2017-05-17T07:44:58Z

    moved single pass test suite to common module

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #919: [CARBONDATA-1056] Added check for starting dictionary...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/919
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2050/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #919: [CARBONDATA-1056] Restrict starting DictionaryServer ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/919
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #919: [CARBONDATA-1056] Restrict starting Dictionary...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/919


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---