[GitHub] carbondata pull request #926: Added set command in carbon to update properti...

[qiuchenjian-2]

GitHub user ravipesala opened a pull request:

    https://github.com/apache/carbondata/pull/926

    Added set command in carbon to update properties dynamically

    The below sql command updates the carbon properties in driver and as well as in executor dynamically in memory.
    ```
    set key1=value1
    ```
   
    It does not update carbon.properties file, it just updates the running driver and executor properties in memory, so after restart of driver all set properties will be gone.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ravipesala/incubator-carbondata setcommand

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/926.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #926
   
----
commit 91e063a31c7ff944e062fed586cb268ee59c89dd
Author: ravipesala <[hidden email]>
Date:   2017-05-18T09:34:17Z

    Added set command in carbon to update properties dynamically

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/926
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2080/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/926#discussion_r117387250
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/NewCarbonDataLoadRDD.scala ---
    @@ -125,12 +126,16 @@ class SparkPartitionLoader(model: CarbonLoadModel,
     
       var storeLocation: String = ""
     
    -  def initialize(): Unit = {
    +  def initialize(addedProperies: util.Map[String, String]): Unit = {
         val carbonPropertiesFilePath = System.getProperty("carbon.properties.filepath", null)
         if (null == carbonPropertiesFilePath) {
           System.setProperty("carbon.properties.filepath",
             System.getProperty("user.dir") + '/' + "conf" + '/' + "carbon.properties")
         }
    +    // Add the properties added in driver to executor.
    +    CarbonProperties.getInstance().setProperties(addedProperies)
    +    // Add the properties added in driver to executor.
    +    CarbonProperties.getInstance().setProperties(addedProperies)
    --- End diff --
   
    duplicated...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/926#discussion_r117387683
 
    --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/hive/execution/command/CarbonHiveCommands.scala ---
    @@ -53,3 +55,15 @@ private[hive] case class DropDatabaseCascadeCommand(dbName: String,
         rows
       }
     }
    +
    +case class CarbonSetCommand(command: SetCommand)
    +  extends RunnableCommand {
    +
    +  override val output = command.output
    +
    +  override def run(sparkSession: SQLContext): Seq[Row] = {
    --- End diff --
   
    name it `sqlContext` would be better


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/926
 
    Hi, I have the following questions:
   
    Will these properties ...
   
    1. be in effect only in current session or until the node restarts ?  `(Effective Scope)`
   
    2. be logged into log file like execution environment variables ?  `(Audit & Tuning)`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala closed the pull request at:

    https://github.com/apache/carbondata/pull/926


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---