[GitHub] carbondata pull request #933: [CARBON DATA-1075] Close Dictionary Server whe...

[qiuchenjian-2]

GitHub user kunal642 opened a pull request:

    https://github.com/apache/carbondata/pull/933

    [CARBON DATA-1075] Close Dictionary Server when application ends

    Analysis: The dictionary server which is started when a load is done with "single_pass=true" is never closed which does not allow the carbon application to exit because it is running on the main thread.
   
    Solution: Add a listener to the sparkContext which closes the server when application ends

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kunal642/incubator-carbondata dictionaryserver_issue

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/933.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #933
   
----
commit d927ed288d920c5125089d72fdc13f4fe690590d
Author: kunal642 <[hidden email]>
Date:   2017-05-21T17:42:59Z

    close dictionary server on application end

commit ea1b4a7f4d8ec8bf0a80cfcc989097949c0065a2
Author: kunal642 <[hidden email]>
Date:   2017-05-21T17:58:48Z

    closed dictionary server for 1.6

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/933
 
    retest this please



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/933
 
    LGTM, but it can work only if user explicitly says context.stop() otherwise won't work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/933


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---