[GitHub] carbondata pull request #984: [CARBONDATA-1008] Make Caron table schema comp...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/984
 
    Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/378/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/984
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2966/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/984
 
    Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/379/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/984
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2967/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/984
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2968/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/984
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2969/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/984
 
    Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/380/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/984
 
    Build Failed with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/381/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user cenyuhai commented on the issue:

    https://github.com/apache/carbondata/pull/984
 
    @chenliang613 can you review this pr?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/984
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2974/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/984
 
    Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/385/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user anubhav100 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/984#discussion_r126336311
 
    --- Diff: integration/hive/hive-guide.md ---
    @@ -41,16 +41,19 @@ mvn -DskipTests -Pspark-2.1 -Phadoop-2.7.2 clean package
     $HADOOP_HOME/bin/hadoop fs -put sample.csv <hdfs store path>/sample.csv
     ```
     
    +
    +Please set spark.carbon.hive.schema.compatibility.enable=true in spark-defaults.conf
     * Start Spark shell by running the following command in the Spark directory
     
    +
     ```
    -./bin/spark-shell --jars <carbondata assembly jar path>
    +./bin/spark-shell --jars <carbondata assembly jar path, carbondata hive jar path>
    --- End diff --
   
    @cenyuhai carbon hive jar won't be required for running the spark shell i guess


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user bhavya411 commented on the issue:

    https://github.com/apache/carbondata/pull/984
 
    Sure Liang,  I will review it today.
   
    Regards
    Bhavya
   
    On Sun, Jul 9, 2017 at 7:39 PM, 岑玉海 <[hidden email]> wrote:
   
    > @chenliang613 <https://github.com/chenliang613> can you review this pr?
    >
    > —
    > You are receiving this because you commented.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/carbondata/pull/984#issuecomment-313922080>,
    > or mute the thread
    > <https://github.com/notifications/unsubscribe-auth/ADlpPikxNdwpDsB4r1_GOEKaNYdUuwMJks5sMN8EgaJpZM4Nrie4>
    > .
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user anubhav100 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/984#discussion_r126410819
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala ---
    @@ -195,11 +195,43 @@ case class CreateTable(cm: TableModel, createDSTable: Boolean = true) extends Ru
               val fields = new Array[Field](cm.dimCols.size + cm.msrCols.size)
               cm.dimCols.foreach(f => fields(f.schemaOrdinal) = f)
               cm.msrCols.foreach(f => fields(f.schemaOrdinal) = f)
    -          sparkSession.sql(
    -            s"""CREATE TABLE $dbName.$tbName
    -                |(${ fields.map(f => f.rawSchema).mkString(",") })
    -                |USING org.apache.spark.sql.CarbonSource""".stripMargin +
    -            s""" OPTIONS (tableName "$tbName", dbName "$dbName", tablePath "$tablePath") """)
    +          val useCompatibleSchema = sparkSession.sparkContext.conf
    +            .getBoolean(CarbonCommonConstants.SPARK_SCHEMA_HIVE_COMPATIBILITY_ENABLE, false)
    +          if (useCompatibleSchema) {
    +            val tableIdentifier = TableIdentifier(tbName, Some(dbName))
    +            val tableSchema = CarbonEnv.getInstance(sparkSession).carbonMetastore
    +              .lookupRelation(tableIdentifier)(sparkSession).schema.json
    +            val schemaParts = AlterTableUtil.prepareSchemaJsonForAlterTable(
    +              sparkSession.sparkContext.conf, tableSchema)
    +            sparkSession.sharedState.externalCatalog.asInstanceOf[HiveExternalCatalog].client
    --- End diff --
   
    @cenyuhai change this code to  sparkSession.sessionState.asInstanceOf[CarbonSessionState].metadataHive beause you can not alter a hive table this table does not exists in carbon metastore
    look below,i tried it and get a exception
   
    cala> carbon.sql("alter table idsr226617624713 add columns(name string) ")
    org.apache.carbondata.spark.exception.MalformedCarbonCommandException: Unsupported alter operation on hive table
    after changing the code it works fine
   



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user cenyuhai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/984#discussion_r126469617
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala ---
    @@ -195,11 +195,43 @@ case class CreateTable(cm: TableModel, createDSTable: Boolean = true) extends Ru
               val fields = new Array[Field](cm.dimCols.size + cm.msrCols.size)
               cm.dimCols.foreach(f => fields(f.schemaOrdinal) = f)
               cm.msrCols.foreach(f => fields(f.schemaOrdinal) = f)
    -          sparkSession.sql(
    -            s"""CREATE TABLE $dbName.$tbName
    -                |(${ fields.map(f => f.rawSchema).mkString(",") })
    -                |USING org.apache.spark.sql.CarbonSource""".stripMargin +
    -            s""" OPTIONS (tableName "$tbName", dbName "$dbName", tablePath "$tablePath") """)
    +          val useCompatibleSchema = sparkSession.sparkContext.conf
    +            .getBoolean(CarbonCommonConstants.SPARK_SCHEMA_HIVE_COMPATIBILITY_ENABLE, false)
    +          if (useCompatibleSchema) {
    +            val tableIdentifier = TableIdentifier(tbName, Some(dbName))
    +            val tableSchema = CarbonEnv.getInstance(sparkSession).carbonMetastore
    +              .lookupRelation(tableIdentifier)(sparkSession).schema.json
    +            val schemaParts = AlterTableUtil.prepareSchemaJsonForAlterTable(
    +              sparkSession.sparkContext.conf, tableSchema)
    +            sparkSession.sharedState.externalCatalog.asInstanceOf[HiveExternalCatalog].client
    --- End diff --
   
    @anubhav100 It is a bug when I merge all commmits into one commit. I will change it tomorrow.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user anubhav100 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/984#discussion_r126592144
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala ---
    @@ -195,11 +195,43 @@ case class CreateTable(cm: TableModel, createDSTable: Boolean = true) extends Ru
               val fields = new Array[Field](cm.dimCols.size + cm.msrCols.size)
               cm.dimCols.foreach(f => fields(f.schemaOrdinal) = f)
               cm.msrCols.foreach(f => fields(f.schemaOrdinal) = f)
    -          sparkSession.sql(
    -            s"""CREATE TABLE $dbName.$tbName
    -                |(${ fields.map(f => f.rawSchema).mkString(",") })
    -                |USING org.apache.spark.sql.CarbonSource""".stripMargin +
    -            s""" OPTIONS (tableName "$tbName", dbName "$dbName", tablePath "$tablePath") """)
    +          val useCompatibleSchema = sparkSession.sparkContext.conf
    +            .getBoolean(CarbonCommonConstants.SPARK_SCHEMA_HIVE_COMPATIBILITY_ENABLE, false)
    +          if (useCompatibleSchema) {
    +            val tableIdentifier = TableIdentifier(tbName, Some(dbName))
    +            val tableSchema = CarbonEnv.getInstance(sparkSession).carbonMetastore
    +              .lookupRelation(tableIdentifier)(sparkSession).schema.json
    +            val schemaParts = AlterTableUtil.prepareSchemaJsonForAlterTable(
    +              sparkSession.sparkContext.conf, tableSchema)
    +            sparkSession.sharedState.externalCatalog.asInstanceOf[HiveExternalCatalog].client
    --- End diff --
   
    @cenyuhai ok change it and also change pr title from caron to carbon


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/984
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/3026/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/984
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/3027/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/984
 
    Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/438/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/984
 
    Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/439/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---