[GitHub] carbondata pull request #985: [CARBONDATA-1102] added integration test cases...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/985
 
    SDV Build Failed with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/266/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user anubhav100 commented on the issue:

    https://github.com/apache/carbondata/pull/985
 
    @cenyuhai @chenliang613 can you review this pr


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/985
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/491/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/985
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/492/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user cenyuhai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/985#discussion_r137942968
 
    --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/CarbonDictionaryDecodeReadSupport.java ---
    @@ -231,11 +231,11 @@ private Writable createWritablePrimitive(Object obj, CarbonColumn carbonColumn)
           case LONG:
             return new LongWritable((long) obj);
           case SHORT:
    -        return new ShortWritable((Short) obj);
    +        return new ShortWritable((short) obj);
    --- End diff --
   
    why ？


---

[qiuchenjian-2]

Github user cenyuhai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/985#discussion_r137942979
 
    --- Diff: integration/hive/pom.xml ---
    @@ -126,20 +126,20 @@
         </dependencies>
     
         <build>
    +        <testSourceDirectory>src/test/scala</testSourceDirectory>
             <resources>
                 <resource>
    -                <directory>src/main/resources</directory>
    +                <directory>src/resources</directory>
    +            </resource>
    +            <resource>
    +                <directory>.</directory>
    +                <includes>
    +                    <include>CARBON_SPARK_INTERFACELogResource.properties</include>
    --- End diff --
   
    when to use this properties？


---

[qiuchenjian-2]

Github user anubhav100 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/985#discussion_r137943182
 
    --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/CarbonDictionaryDecodeReadSupport.java ---
    @@ -231,11 +231,11 @@ private Writable createWritablePrimitive(Object obj, CarbonColumn carbonColumn)
           case LONG:
             return new LongWritable((long) obj);
           case SHORT:
    -        return new ShortWritable((Short) obj);
    +        return new ShortWritable((short) obj);
    --- End diff --
   
    there is merge conflict in this file i will rebase it


---

[qiuchenjian-2]

Github user anubhav100 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/985#discussion_r137943202
 
    --- Diff: integration/hive/pom.xml ---
    @@ -126,20 +126,20 @@
         </dependencies>
     
         <build>
    +        <testSourceDirectory>src/test/scala</testSourceDirectory>
             <resources>
                 <resource>
    -                <directory>src/main/resources</directory>
    +                <directory>src/resources</directory>
    +            </resource>
    +            <resource>
    +                <directory>.</directory>
    +                <includes>
    +                    <include>CARBON_SPARK_INTERFACELogResource.properties</include>
    --- End diff --
   
    not needed i will correct it


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/985
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/65/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/985
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/751/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/985
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/752/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/985
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/758/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/985
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/759/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/985
 
    Build Failed with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/9/



---

[qiuchenjian-2]

Github user anubhav100 commented on the issue:

    https://github.com/apache/carbondata/pull/985
 
    retest this please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/985
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/762/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/985
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/140/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/985
 
    Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/14/



---

[qiuchenjian-2]

Github user anubhav100 commented on the issue:

    https://github.com/apache/carbondata/pull/985
 
    this pr required #1356 to be merged first because of wrong values of date type issue in hive


---

[qiuchenjian-2]

Github user anubhav100 commented on the issue:

    https://github.com/apache/carbondata/pull/985
 
    retest this please


---