[GitHub] [carbondata] qiuchenjian commented on a change in pull request #3101: [CARBONDATA-3270] MV support groupby columns don't need be existed in the projection

[GitBox]

qiuchenjian commented on a change in pull request #3101: [CARBONDATA-3270] MV support groupby columns don't need be existed in the projection
URL: https://github.com/apache/carbondata/pull/3101#discussion_r276092670
 
 

 ##########
 File path: datamap/mv/core/src/test/scala/org/apache/carbondata/mv/rewrite/MVCreateTestCase.scala
 ##########
 @@ -829,16 +829,14 @@ class MVCreateTestCase extends QueryTest with BeforeAndAfterAll {
   test("jira carbondata-2533") {
 
     sql("drop datamap if exists MV_exp")
-    intercept[UnsupportedOperationException] {
-      sql(
-        "create datamap MV_exp using 'mv' as select sum(case when deptno=11 and (utilization=92) then salary else 0 end) as t from fact_table1 group by empname")
+    sql(
+      "create datamap MV_exp using 'mv' as select sum(case when deptno=11 and (utilization=92) then salary else 0 end) as t from fact_table1 group by empname")
 
-      sql("rebuild datamap MV_exp")
-      val frame = sql(
-        "select sum(case when deptno=11 and (utilization=92) then salary else 0 end) as t from fact_table1 group by empname")
-      val analyzed = frame.queryExecution.analyzed
-      assert(verifyMVDataMap(analyzed, "MV_exp"))
-    }
+    sql("rebuild datamap MV_exp")
 
 Review comment:
   done， the name is above

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services