[GitHub] [carbondata] qiuchenjian commented on a change in pull request #3135: [CARBONDATA-3303] Fix that MV datamap return wrong results when using coalesce and less groupby columns

[GitBox]

qiuchenjian commented on a change in pull request #3135: [CARBONDATA-3303] Fix that MV datamap return wrong results when using coalesce and less groupby columns
URL: https://github.com/apache/carbondata/pull/3135#discussion_r285419089
 
 

 ##########
 File path: datamap/mv/core/src/main/scala/org/apache/carbondata/mv/datamap/MVHelper.scala
 ##########
 @@ -172,6 +172,17 @@ object MVHelper {
     if (catalog.isMVWithSameQueryPresent(logicalPlan)) {
       throw new UnsupportedOperationException("MV with same query present")
     }
+
+    var expressionValid = true
+    modularPlan.transformExpressions {
+      case coal@Coalesce(_) =>
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services