[GitHub] [carbondata] qiuchenjian commented on a change in pull request #3140: [CARBONDATA-3307] Fix Performance Issue in No Sort

[GitBox]

qiuchenjian commented on a change in pull request #3140: [CARBONDATA-3307] Fix Performance Issue in No Sort
URL: https://github.com/apache/carbondata/pull/3140#discussion_r263212008
 
 

 ##########
 File path: processing/src/main/java/org/apache/carbondata/processing/loading/steps/CarbonRowDataWriterProcessorStepImpl.java
 ##########
 @@ -157,31 +163,14 @@ public CarbonRowDataWriterProcessorStepImpl(CarbonDataLoadConfiguration configur
     return null;
   }
 
-  private void doExecute(Iterator<CarbonRowBatch> iterator, int iteratorIndex) throws IOException {
-    String[] storeLocation = getStoreLocation();
-    DataMapWriterListener listener = getDataMapWriterListener(0);
-    CarbonFactDataHandlerModel model = CarbonFactDataHandlerModel.createCarbonFactDataHandlerModel(
-        configuration, storeLocation, 0, iteratorIndex, listener);
-    model.setColumnLocalDictGenMap(localDictionaryGeneratorMap);
-    CarbonFactHandler dataHandler = null;
+  private void doExecute(Iterator<CarbonRowBatch> iterator, int iteratorIndex, CarbonFactHandler dataHandler) throws IOException {
 
 Review comment:
   Does this line exceed this max length ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services