[GitHub] [carbondata] qiuchenjian commented on a change in pull request #3162: [CARBONDATA-3330] Fix Invalid Exception while clearing datamap from SDK carbon reader

[GitBox]

qiuchenjian commented on a change in pull request #3162: [CARBONDATA-3330] Fix Invalid Exception while clearing datamap from SDK carbon reader
URL: https://github.com/apache/carbondata/pull/3162#discussion_r268588818
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/datamap/DataMapStoreManager.java
 ##########
 @@ -492,12 +491,15 @@ public void clearDataMaps(AbsoluteTableIdentifier identifier, boolean launchJob)
         tableIndices = allDataMaps.get(tableUniqueName);
       }
     }
-    if (null != carbonTable && tableIndices != null && launchJob) {
-      try {
-        DataMapUtil.executeDataMapJobForClearingDataMaps(carbonTable);
-      } catch (IOException e) {
-        LOGGER.error("clear dataMap job failed", e);
-        // ignoring the exception
+    if (launchJob) {
+      CarbonTable carbonTable = getCarbonTable(identifier);
+      if (null != carbonTable && tableIndices != null) {
 
 Review comment:
   you can also judge tableIndices != null , then getCarbonTable, such as:
   if (launchJob && tableIndices != null)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services