[GitHub] [carbondata] qiuchenjian commented on a change in pull request #3176: [CARBONDATA-3353 ]Fixed MinMax Based Pruning for Measure column in case of Legacy store

[GitBox]

qiuchenjian commented on a change in pull request #3176: [CARBONDATA-3353 ]Fixed  MinMax Based Pruning for Measure column in case of Legacy store
URL: https://github.com/apache/carbondata/pull/3176#discussion_r274795583
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelRangeLessThanFilterExecuterImpl.java
 ##########
 @@ -120,9 +120,13 @@ private void ifDefaultValueMatchesFilter() {
     boolean isScanRequired = false;
     if (isMeasurePresentInCurrentBlock[0] || isDimensionPresentInCurrentBlock[0]) {
       if (isMeasurePresentInCurrentBlock[0]) {
-        minValue = blockMinValue[measureChunkIndex[0]];
-        isScanRequired =
-            isScanRequired(minValue, msrFilterRangeValues, msrColEvalutorInfoList.get(0).getType());
+        if (isMinMaxSet[measureChunkIndex[0]]) {
+          minValue = blockMinValue[measureChunkIndex[0]];
+          isScanRequired = isScanRequired(minValue, msrFilterRangeValues,
+              msrColEvalutorInfoList.get(0).getType());
+        } else {
+          isScanRequired = true;
+        }
 
 Review comment:
   Does RangeValueFilterExecuterImpl have this issue?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services