[GitHub] [carbondata] qiuchenjian commented on issue #3130: [CARBONDATA-3297] Fix that the IndexoutOfBoundsException when creating table and dropping table are at the same time

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] qiuchenjian commented on issue #3130: [CARBONDATA-3297] Fix that the IndexoutOfBoundsException when creating table and dropping table are at the same time

GitBox
qiuchenjian commented on issue #3130: [CARBONDATA-3297] Fix that the IndexoutOfBoundsException when creating table and dropping table are at the same time
URL: https://github.com/apache/carbondata/pull/3130#issuecomment-471416326
 
 
   > > > @qiuchenjian i think red lock should be added for `listAllTables` APi also, please check it once
   > >
   > >
   > > @akashrn5
   > > done!
   > > I also clone a new seq, besause it's useless that return the same ArrayBuffer
   > > Please review and merge, thank you
   >
   > @qiuchenjian sorry i did not get this `besause it's useless that return the same ArrayBuffer`
   
   @akashrn5
   I mean that if "listAllTables" return "carbonTables" directly and the readLock is finished, "carbonTables" will be traversed without protection of lock
   so i return a clone of "carbonTables", it's thread-safe

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services