qiuchenjian opened a new pull request #3291: [CARBONDATA-3247] Support to select all columns when creating MV datamap
URL:
https://github.com/apache/carbondata/pull/3291
PR-3072 has LGTM and this pr has the same code with 3072 and merge one commit
[Problem]
"create table all_table(name string, age int, height int) stored by 'carbondata'"
"create datamap all_table_mv on table all_table using 'mv' as select avg(age),avg(height),name from all_table group by name"
throw UnsupportedOperationException("MV is not supported for this query")
[Cause]
ColumnPruning rule will not generate Project LogicalPlan when select all columns, So carbon can't generate SELECT node when transforming LogicalPlan to ModularPlan, then it can't create mv datamap
[Solution]
Add a executor rule to change the logical plan to support this scene
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]
With regards,
Apache Git Services
Locked
