ravipesala commented on a change in pull request #3072: [CARBONDATA-3247] Support to select all columns when creating MV datamap
URL:
https://github.com/apache/carbondata/pull/3072#discussion_r281605624
##########
File path: datamap/mv/plan/src/main/scala/org/apache/carbondata/mv/plans/util/BirdcageOptimizer.scala
##########
@@ -132,7 +133,9 @@ object BirdcageOptimizer extends RuleExecutor[LogicalPlan] {
Batch(
"RewriteSubquery", Once,
RewritePredicateSubquery,
- CollapseProject) :: Nil
+ CollapseProject) ::
+ Batch(
+ "MVProjectAdd", Once, MVProjectColumnsAdd)::Nil
Review comment:
@kevinjmh It is not that he is removing a useless project, he is adding a project so that sql generation in mv core will not fail. Instead of solving the failure in SQL generation, he is trying to add another project as a workaround.
What I am asking is better fix the issue than adding the workarounds.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]
With regards,
Apache Git Services
Locked
