[GitHub] [carbondata] ravipesala commented on a change in pull request #3129: [CARBONDATA-3295] Fix that MV datamap throw exception because its rewrite algorithm when query SQL has multiply subquery

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ravipesala commented on a change in pull request #3129: [CARBONDATA-3295] Fix that MV datamap throw exception because its rewrite algorithm when query SQL has multiply subquery

GitBox
ravipesala commented on a change in pull request #3129: [CARBONDATA-3295] Fix that MV datamap throw exception because its rewrite algorithm when query SQL has multiply subquery
URL: https://github.com/apache/carbondata/pull/3129#discussion_r282845255
 
 

 ##########
 File path: datamap/mv/plan/src/main/scala/org/apache/carbondata/mv/plans/modular/basicOperators.scala
 ##########
 @@ -74,6 +92,25 @@ case class Select(
   override def extractEvaluableConditions(plan: ModularPlan): Seq[Expression] = {
     predicateList.filter(p => canEvaluate(p, plan))
   }
+
+  /**
+   *  Comparison excluding children
+   */
+  def coarseEqual(other: Any): Boolean = {
 
 Review comment:
   This code is not needed, please remove

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services