[GitHub] [carbondata] ravipesala commented on a change in pull request #3148: [CARBONDATA-3293] Prune datamaps improvement for count(*)

[GitBox]

ravipesala commented on a change in pull request #3148: [CARBONDATA-3293] Prune datamaps improvement for count(*)
URL: https://github.com/apache/carbondata/pull/3148#discussion_r266324853
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/datamap/dev/DataMap.java
 ##########
 @@ -54,6 +56,13 @@ void init(DataMapModel dataMapModel)
   List<T> prune(Expression filter, SegmentProperties segmentProperties,
       List<PartitionSpec> partitions, CarbonTable carbonTable) throws IOException;
 
+  /**
+   * Prune the data maps for finding the row count. It returns a Map of
+   * blockletpath and the row count
+   */
+  Map<String, Long> getRowCount(Segment segment, List<PartitionSpec> partitions,
+      Map<String, Long> blockletToRowCountMap, boolean isUpdateFlow) throws IOException;
 
 Review comment:
   I don't think datamap interface users need to know about update flow. Make it simplified, add another method to get all row count. So add two methods instead of one method for simplification.
   ```
   getRowCountForEachBlock()
   getRowCount()
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services