[GitHub] [carbondata] ravipesala commented on a change in pull request #3173: [CARBONDATA-3351] Support Binary Data Type

[GitBox]

ravipesala commented on a change in pull request #3173: [CARBONDATA-3351] Support Binary Data Type
URL: https://github.com/apache/carbondata/pull/3173#discussion_r276084188
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/AbstractNonDictionaryVectorFiller.java
 ##########
 @@ -168,6 +170,31 @@ public LongStringVectorFiller(int numberOfRows, int actualDataLength) {
   }
 }
 
+class BinaryVectorFiller extends AbstractNonDictionaryVectorFiller {
 
 Review comment:
   This code

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services