[GitHub] [carbondata] ravipesala commented on a change in pull request #3173: [CARBONDATA-3351] Support Binary Data Type

[GitBox]

ravipesala commented on a change in pull request #3173: [CARBONDATA-3351] Support Binary Data Type
URL: https://github.com/apache/carbondata/pull/3173#discussion_r276086564
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/metadata/datatype/DataType.java
 ##########
 @@ -99,6 +99,8 @@ public static char convertType(DataType dataType) {
       return DATE_CHAR;
     } else if (dataType == DataTypes.BYTE_ARRAY) {
       return BYTE_ARRAY_CHAR;
+    } else if (dataType == DataTypes.BINARY) {
 
 Review comment:
   you can keep `||` in above `if` condition, no need of new if condition

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services