Apache CarbonData Dev Mailing List archive › Apache CarbonData JIRA issues

[GitHub] [carbondata] ravipesala commented on a change in pull request #3173: [CARBONDATA-3351] Support Binary Data Type

Classic

List

Threaded

1 message

GitBox

[GitHub] [carbondata] ravipesala commented on a change in pull request #3173: [CARBONDATA-3351] Support Binary Data Type

ravipesala commented on a change in pull request #3173: [CARBONDATA-3351] Support Binary Data Type
URL: https://github.com/apache/carbondata/pull/3173#discussion_r276093704

##########
File path: integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/binary/TestBinaryDataType.scala
##########
@@ -0,0 +1,425 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.carbondata.integration.spark.testsuite.binary
+
+import java.util.Arrays
+import org.apache.carbondata.common.exceptions.sql.MalformedCarbonCommandException
+import org.apache.carbondata.core.constants.CarbonCommonConstants
+import org.apache.carbondata.core.metadata.CarbonMetadata
+import org.apache.carbondata.core.metadata.schema.table.CarbonTable
+import org.apache.carbondata.core.util.CarbonProperties
+import org.apache.commons.codec.binary.Hex
+import org.apache.spark.sql.Row
+import org.apache.spark.sql.test.util.QueryTest
+import org.scalatest.BeforeAndAfterAll
+
+/**
+ * Test cases for testing binary
+ */
+class TestBinaryDataType extends QueryTest with BeforeAndAfterAll {
+ override def beforeAll {
+ }
+
+ test("Create table and load data with binary column") {
+ sql("DROP TABLE IF EXISTS binaryTable")
+ sql(
+ s"""
+ | CREATE TABLE IF NOT EXISTS binaryTable (
+ | id int,
+ | label boolean,
+ | name string,
+ | image binary,
+ | autoLabel boolean)
+ | STORED BY 'carbondata'
+ | TBLPROPERTIES('SORT_COLUMNS'='')
+ """.stripMargin)
+ sql(
+ s"""
+ | LOAD DATA LOCAL INPATH '$resourcesPath/binarydata.csv'
+ | INTO TABLE binaryTable
+ | OPTIONS('header'='false')
+ """.stripMargin)
+
+ val result = sql("desc formatted binaryTable").collect()
+ var flag = false
+ result.foreach { each =>
+ if ("binary".equals(each.get(1))) {
+ flag = true
+ }
+ }
+ assert(flag)
+
+ checkAnswer(sql("SELECT COUNT(*) FROM binaryTable"), Seq(Row(3)))
+ try {
+ val df = sql("SELECT * FROM binaryTable").collect()
+ assert(3 == df.length)
+ df.foreach { each =>
+ assert(5 == each.length)
+
+ assert(Integer.valueOf(each(0).toString) > 0)
+ assert(each(1).toString.equalsIgnoreCase("false") || (each(1).toString.equalsIgnoreCase("true")))
+ assert(each(2).toString.contains(".png"))
+
+ val bytes40 = each.getAs[Array[Byte]](3).slice(0, 40)
+ val binaryName = each(2).toString
+ val expectedBytes = Hex.encodeHex(firstBytes20.get(binaryName).get)
+ assert(Arrays.equals(String.valueOf(expectedBytes).getBytes(), bytes40), "incorrect numeric value for flattened image")
+
+ assert(each(4).toString.equalsIgnoreCase("false") || (each(4).toString.equalsIgnoreCase("true")))
+
+ val df = sql("SELECT name,image FROM binaryTable").collect()
+ assert(3 == df.length)
+ df.foreach { each =>
+ assert(2 == each.length)
+ val binaryName = each(0).toString
+ val bytes40 = each.getAs[Array[Byte]](1).slice(0, 40)
+ val expectedBytes = Hex.encodeHex(firstBytes20.get(binaryName).get)
+ assert(Arrays.equals(String.valueOf(expectedBytes).getBytes(), bytes40), "incorrect numeric value for flattened image")
+ }
+ }
+ } catch {
+ case e: Exception =>
+ e.printStackTrace()
+ assert(false)
+ }
+ }
+
+ private val firstBytes20 = Map("1.png" -> Array[Byte](-119, 80, 78, 71, 13, 10, 26, 10, 0, 0, 0, 13, 73, 72, 68, 82, 0, 0, 1, 74),
+ "2.png" -> Array[Byte](-119, 80, 78, 71, 13, 10, 26, 10, 0, 0, 0, 13, 73, 72, 68, 82, 0, 0, 2, -11),
+ "3.png" -> Array[Byte](-119, 80, 78, 71, 13, 10, 26, 10, 0, 0, 0, 13, 73, 72, 68, 82, 0, 0, 1, 54)
+ )
+
+ test("Don't support sort_columns") {
+ sql("DROP TABLE IF EXISTS binaryTable")
+ val exception = intercept[Exception] {
+ sql(
+ s"""
+ | CREATE TABLE IF NOT EXISTS binaryTable (
+ | id double,
+ | label boolean,
+ | name STRING,
+ | image BINARY,
+ | autoLabel boolean)
+ | STORED BY 'carbondata'
+ | TBLPROPERTIES('SORT_COLUMNS'='image')
+ """.stripMargin)
+ }
+ assert(exception.getMessage.contains("sort_columns is unsupported for binary datatype column"))
+ }
+
+ test("Unsupport LOCAL_DICTIONARY_INCLUDE for binary") {
+
+ sql("DROP TABLE IF EXISTS binaryTable")
+ val exception = intercept[MalformedCarbonCommandException] {
+ sql(
+ """
+ | CREATE TABLE binaryTable(
+ | id int,
+ | name string,
+ | city string,
+ | age int,
+ | image binary)
+ | STORED BY 'org.apache.carbondata.format'
+ | tblproperties('local_dictionary_enable'='true','local_dictionary_include'='image')
+ """.stripMargin)
+ }
+ assert(exception.getMessage.contains(
+ "LOCAL_DICTIONARY_INCLUDE/LOCAL_DICTIONARY_EXCLUDE column: image is not a string/complex/varchar datatype column. " +
+ "LOCAL_DICTIONARY_COLUMN should be no dictionary string/complex/varchar datatype column"))
+ }
+
+ test("COLUMN_META_CACHE doesn't support binary") {
+ sql("DROP TABLE IF EXISTS binaryTable")
+ val exception = intercept[Exception] {
+ sql(
+ s"""
+ | CREATE TABLE IF NOT EXISTS binaryTable (
+ | id INT,
+ | label boolean,
+ | name STRING,
+ | image BINARY,
+ | autoLabel boolean)
+ | STORED BY 'carbondata'
+ | TBLPROPERTIES('COLUMN_META_CACHE'='image')
+ """.stripMargin)
+ }
+ assert(exception.getMessage.contains("image is a binary data type column and binary data type is not allowed for the option"))
+ }
+
+ test("RANGE_COLUMN doesn't support binary") {
+ sql("DROP TABLE IF EXISTS binaryTable")
+ val exception = intercept[Exception] {
+ sql(
+ s"""
+ | CREATE TABLE IF NOT EXISTS binaryTable (
+ | id INT,
+ | label boolean,
+ | name STRING,
+ | image BINARY,
+ | autoLabel boolean)
+ | STORED BY 'carbondata'
+ | TBLPROPERTIES('RANGE_COLUMN'='image')
+ """.stripMargin)
+ }
+ assert(exception.getMessage.contains("RANGE_COLUMN doesn't support binary data type"))
+ }
+
+ test("Test carbon.column.compressor=zstd") {
+ sql("DROP TABLE IF EXISTS binaryTable")
+ sql(
+ s"""
+ | CREATE TABLE IF NOT EXISTS binaryTable (
+ | id INT,
+ | label boolean,
+ | name STRING,
+ | image BINARY,
+ | autoLabel boolean)
+ | STORED BY 'carbondata'
+ | TBLPROPERTIES('carbon.column.compressor'='zstd')
+ """.stripMargin)
+ sql(
+ s"""
+ | LOAD DATA LOCAL INPATH '$resourcesPath/binarydata.csv'
+ | INTO TABLE binaryTable
+ | OPTIONS('header'='false')
+ """.stripMargin)
+ checkAnswer(sql("SELECT COUNT(*) FROM binaryTable"), Seq(Row(3)))
+ val value = sql("SELECT * FROM binaryTable").collect()
+ value.foreach { each =>
+ assert(5 == each.length)
+ }
+ }
+
+ test("Support filter other column in binary table") {
+ sql("DROP TABLE IF EXISTS binaryTable")
+ sql(
+ s"""
+ | CREATE TABLE IF NOT EXISTS binaryTable (
+ | id INT,
+ | label boolean,
+ | name STRING,
+ | image BINARY,
+ | autoLabel boolean)
+ | STORED BY 'carbondata'
+ | TBLPROPERTIES('carbon.column.compressor'='zstd')
+ """.stripMargin)
+ sql(
+ s"""
+ | LOAD DATA LOCAL INPATH '$resourcesPath/binarydata.csv'
+ | INTO TABLE binaryTable
+ | OPTIONS('header'='false')
+ """.stripMargin)
+ checkAnswer(sql("SELECT COUNT(*) FROM binaryTable where id =1"), Seq(Row(1)))
+ //TODO: support filter binary
+ checkAnswer(sql("SELECT COUNT(*) FROM binaryTable where image ='hello'"), Seq(Row(0)))
+ }
+
+ test("Test create table with buckets unsafe") {
+ CarbonProperties.getInstance().addProperty(CarbonCommonConstants.ENABLE_UNSAFE_SORT, "true")
+ sql("DROP TABLE IF EXISTS binaryTable")
+ sql(
+ s"""
+ | CREATE TABLE IF NOT EXISTS binaryTable (
+ | id INT,
+ | label boolean,
+ | name STRING,
+ | image BINARY,
+ | autoLabel boolean)
+ | STORED BY 'carbondata'
+ | TBLPROPERTIES('BUCKETNUMBER'='4', 'BUCKETCOLUMNS'='image')
+ """.stripMargin)
+ sql(
+ s"""
+ | LOAD DATA LOCAL INPATH '$resourcesPath/binarydata.csv'
+ | INTO TABLE binaryTable
+ | OPTIONS('header'='false')
+ """.stripMargin)
+
+ CarbonProperties.getInstance().addProperty(CarbonCommonConstants.ENABLE_UNSAFE_SORT, "false")
+ val table: CarbonTable = CarbonMetadata.getInstance().getCarbonTable("default", "binaryTable")
+ if (table != null && table.getBucketingInfo("binarytable") != null) {
+ assert(true)
+ } else {
+ assert(false, "Bucketing info does not exist")
+ }
+ }
+
+ test("insert into for hive and carbon") {
+ sql("DROP TABLE IF EXISTS hiveTable")
+ sql("DROP TABLE IF EXISTS carbontable")
+
+ sql(
+ s"""
+ | CREATE TABLE IF NOT EXISTS hivetable (
+ | id int,
+ | label boolean,
+ | name string,
+ | image binary,
+ | autoLabel boolean)
+ | row format delimited fields terminated by ','
+ """.stripMargin)
+ sql("insert into hivetable values(1,true,'Bob','binary',false)")
+ sql("insert into hivetable values(2,false,'Xu','test',true)")
+ val hiveResult = sql("SELECT * FROM hivetable")
+
+ sql(
+ s"""
+ | CREATE TABLE IF NOT EXISTS carbontable (
+ | id int,
+ | label boolean,
+ | name string,
+ | image binary,
+ | autoLabel boolean)
+ | STORED BY 'carbondata'
+ """.stripMargin)
+ sql("insert into carbontable values(1,true,'Bob','binary',false)")
+ sql("insert into carbontable values(2,false,'Xu','test',true)")
+
+ val carbonResult = sql("SELECT * FROM carbontable")
+ checkAnswer(hiveResult, carbonResult)
+ }
+
+ // TODO: support filter
+ ignore("Support filter for hive and carbon") {
+ sql("DROP TABLE IF EXISTS hiveTable")
+ sql("DROP TABLE IF EXISTS carbontable")
+
+ sql(
+ s"""
+ | CREATE TABLE IF NOT EXISTS hivetable (
+ | id int,
+ | label boolean,
+ | name string,
+ | image binary,
+ | autoLabel boolean)
+ | row format delimited fields terminated by ','
+ """.stripMargin)
+ sql("insert into hivetable values(1,true,'Bob','binary',false)")
+ sql("insert into hivetable values(2,false,'Xu','test',true)")
+ val hiveResult = sql("SELECT * FROM hivetable where image='binary'")
+
+ sql(
+ s"""
+ | CREATE TABLE IF NOT EXISTS carbontable (
+ | id int,
+ | label boolean,
+ | name string,
+ | image binary,
+ | autoLabel boolean)
+ | STORED BY 'carbondata'
+ """.stripMargin)
+ sql("insert into carbontable values(1,true,'Bob','binary',false)")
+ sql("insert into carbontable values(2,false,'Xu','test',true)")
+ val carbonResult = sql("SELECT * FROM carbontable where image='binary'")
+ hiveResult.show()
+ carbonResult.show()
+ checkAnswer(hiveResult, carbonResult)
+ carbonResult.collect().foreach { each =>
+ if (1 == each.get(0)) {
+ "binary".equals(new String(each.getAs[Array[Byte]](3)))
+ } else if (2 == each.get(0)) {
+ "test".equals(new String(each.getAs[Array[Byte]](3)))
+ } else {
+ assert(false)
+ }
+ }
+ }
+
+ test("Create table and load data with binary column for hive") {

Review comment:
No need a separate test case, all newly added tests should be compared with hive

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

With regards,
Apache Git Services