ravipesala commented on a change in pull request #3178: [CARBONDATA-3348] Support alter SORT_COLUMNS property
URL:
https://github.com/apache/carbondata/pull/3178#discussion_r277226373
##########
File path: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonInputFormat.java
##########
@@ -487,7 +487,7 @@ private int getBlockCount(List<ExtendedBlocklet> blocklets) {
List<ExtendedBlocklet> prunedBlocklets = null;
// This is to log the event, so user will know what is happening by seeing logs.
LOG.info("Started block pruning ...");
- if (carbonTable.isTransactionalTable()) {
+ if (carbonTable.isTransactionalTable() && !carbonTable.hasColumnDrift()) {
Review comment:
I feel it is better check this `hasColumnDrift` on individual segement properties rather than CarbonTable. CarbonTable is always updated with latest schema. So once the compaction of old segements happen then all the old segments are updated with latest schema then this `hasColumnDrift` does not make sense.
In the below code going to else block is basically costly operation as it needs to resolve the filter expression per each segment. So I feel it should be better if we have one more check to compare whether the current schema and segment schema has different columnDrift
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]
With regards,
Apache Git Services
Locked
