[GitHub] [carbondata] ravipesala commented on a change in pull request #3179: [CARBONDATA-3338] Support Incremental DataLoad for MV Datamap[with single parent table]

[GitBox]

ravipesala commented on a change in pull request #3179: [CARBONDATA-3338] Support Incremental DataLoad for MV Datamap[with single parent table]
URL: https://github.com/apache/carbondata/pull/3179#discussion_r279241157
 
 

 ##########
 File path: processing/src/main/java/org/apache/carbondata/processing/merger/CarbonDataMergerUtil.java
 ##########
 @@ -351,6 +357,27 @@ public static boolean updateLoadMetadataWithMergeStatus(List<LoadMetadataDetails
           loadMetadataDetails.setMajorCompacted("true");
         }
 
+        if (DataMapUtil.isMVdatamapTable(carbonTable)) {
 
 Review comment:
   I think it is not a good way to check whether it is MV table or not here. It should be checked in generic like it is child table or not? If it is child table get the extrainfo and fill it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services