[GitHub] [carbondata] ravipesala commented on a change in pull request #3182: [WIP] [CARBONDATA-3343] Compaction for Range Sort

[GitBox]

ravipesala commented on a change in pull request #3182: [WIP] [CARBONDATA-3343] Compaction for Range Sort
URL: https://github.com/apache/carbondata/pull/3182#discussion_r277649451
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/scan/result/impl/FilterQueryScannedResult.java
 ##########
 @@ -54,7 +55,28 @@ public FilterQueryScannedResult(BlockExecutionInfo tableBlockExecutionInfos,
   }
 
   @Override public List<byte[]> getDictionaryKeyArrayBatch(int batchSize) {
-    throw new UnsupportedOperationException("Operation not supported");
+    // rowId from where computing need to start
 
 Review comment:
   This method seems duplicated. Move this method to `BlockletScannedResult` and create an abstract method `fillValidRowIdsBatchFilling` and override in both implementation classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services