[GitHub] [carbondata] ravipesala commented on a change in pull request #3182: [WIP] [CARBONDATA-3343] Compaction for Range Sort

[GitBox]

ravipesala commented on a change in pull request #3182: [WIP] [CARBONDATA-3343] Compaction for Range Sort
URL: https://github.com/apache/carbondata/pull/3182#discussion_r277650278
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/scan/result/impl/FilterQueryScannedResult.java
 ##########
 @@ -81,7 +103,24 @@ public FilterQueryScannedResult(BlockExecutionInfo tableBlockExecutionInfos,
   }
 
   @Override public List<byte[][]> getNoDictionaryKeyArrayBatch(int batchSize) {
-    throw new UnsupportedOperationException("Operation not supported");
+    List<byte[][]> noDictionaryKeyArrayList = new ArrayList<>(validRowIds.size());
 
 Review comment:
   This method also duplicated, please move to `BlockletScannedResult`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services