[GitHub] [carbondata] ravipesala commented on a change in pull request #3201: [CARBONDATA-3371] Fix ArrayIndexOutOfBoundsException of compaction after sort_columns modification

[GitBox]

ravipesala commented on a change in pull request #3201: [CARBONDATA-3371] Fix ArrayIndexOutOfBoundsException of compaction after sort_columns modification
URL: https://github.com/apache/carbondata/pull/3201#discussion_r281502992
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/scan/result/iterator/RawResultIterator.java
 ##########
 @@ -66,18 +81,62 @@
 
   public RawResultIterator(CarbonIterator<RowBatch> detailRawQueryResultIterator,
       SegmentProperties sourceSegProperties, SegmentProperties destinationSegProperties,
-      boolean isStreamingHandoff) {
+      boolean isStreamingHandoff, boolean hasColumnDrift) {
 
 Review comment:
   If possible we can create new class and extend this class and override the convertRow method for better readability

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services