[GitHub] [carbondata] ravipesala commented on a change in pull request #3216: [CARBONDATA-3387] Support Partition with MV datamap & Show DataMap Status

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ravipesala commented on a change in pull request #3216: [CARBONDATA-3387] Support Partition with MV datamap & Show DataMap Status

GitBox
ravipesala commented on a change in pull request #3216: [CARBONDATA-3387] Support Partition with MV datamap & Show DataMap Status
URL: https://github.com/apache/carbondata/pull/3216#discussion_r285664653
 
 

 ##########
 File path: datamap/mv/core/src/main/scala/org/apache/carbondata/mv/datamap/MVHelper.scala
 ##########
 @@ -694,5 +731,28 @@ object MVHelper {
       rewrittenPlan
     }
   }
+
+  private def getUpdatedOutputList(outputList: Seq[NamedExpression],
 
 Review comment:
   ```
    private def getUpdatedOutputList(outputList: Seq[NamedExpression],
         dataMapTableRelation: Option[ModularPlan]): Seq[NamedExpression] = {
       dataMapTableRelation.collect {
         case mv: MVPlanWrapper =>
           val dataMapSchema = mv.dataMapSchema
           val columnsOrderMap = dataMapSchema.getColumnsOrderMap
           if (null != columnsOrderMap && !columnsOrderMap.isEmpty) {
             val updatedOutputList = new util.ArrayList[NamedExpression]()
             var i = 0
             while (i < columnsOrderMap.size()) {
               updatedOutputList
                 .add(outputList.filter(f => f.name.equalsIgnoreCase(columnsOrderMap.get(i))).head)
               i = i + 1
             }
             updatedOutputList.asScala
           } else {
             outputList
           }
         case _ => outputList
       }.get
     }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services